[TikiWiki-commits] [Git][tikiwiki/tiki][30.x] [FIX] prefixalias: The itemId was getting removed

Jonny Bradley pushed to branch 30.x at Tiki Wiki CMS Groupware / Tiki


Commits:
53b8bb0d by Jonny Bradley at 2026-06-03T12:28:09+00:00
[FIX] prefixalias: The itemId was getting removed
---
* [FIX] prefixalias: The itemId was getting removed
---
* [FIX] prefixalias: The itemId was getting removed in `$wikilib->sefurl` so adapt `get_trackeritem_pagealias` to keep the seful (or not) page name/slug separate and add the itemId after

See merge request tikiwiki/tiki!10253


(cherry picked from commit 0a6d950e04b2b74ddc015c3bd2848253d5f09205)

7f08ceaa [FIX] prefixalias: The itemId was getting removed in `$wikilib->sefurl` so...

Co-authored-by: Jonny Bradley <[email protected]>

See merge request tikiwiki/tiki!10367


(cherry picked from commit aa93dda096bdfd651f4bb3553c741611e4c9dc25)

a1be42fb [FIX] prefixalias: The itemId was getting removed

Co-authored-by: luci <gitlab-TfYQc8/[email protected]>
- - - - -


3 changed files:

- lib/smarty_tiki/Modifier/Sefurl.php
- lib/trackers/trackerlib.php
- tiki-sefurl.php


Changes:

=====================================
lib/smarty_tiki/Modifier/Sefurl.php
=====================================
@@ -129,6 +129,11 @@ class Sefurl
                 }
                 if ($replacementpage) {
                     $href = \TikiLib::tikiUrlOpt($wikilib->sefurl($replacementpage, $with_next, $all_langs));
+                    if ($prefs['feature_sefurl'] === 'y') {
+                        $href .= $source;
+                    } else {
+                        $href .= "&itemId=$source";
+                    }
                     if ($prefs['feature_sefurl_title_trackeritem'] == 'y') {
                         $title = $trklib->get_title_sefurl($source);
                     }


=====================================
lib/trackers/trackerlib.php
=====================================
@@ -961,7 +961,7 @@ class TrackerLib extends TikiLib
 
             $p_links = $semanticlib->getLinksUsing('prefixalias', ['fromPage' => $target]);
             if (count($p_links)) {
-                $ret = $p_links[0]['toPage'] . $itemId;
+                $ret = $p_links[0]['toPage'];
                 return $ret;
             } else {
                 return false;


=====================================
tiki-sefurl.php
=====================================
@@ -115,7 +115,7 @@ function filter_out_sefurl($tpl_output, $type = null, $title = '', $with_next =
                     $pagealias = $trklib->get_trackeritem_pagealias($matches[1])
             ) {
                 $title = '';
-                $tpl_output = "./tiki-index.php?page=" . $pagealias;
+                $tpl_output = "./tiki-index.php?page={$pagealias}&itemId={$matches[1]}";
             }
         }
     }



View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/53b8bb0dfec7666f19ce991be9143d35f91acdff

-- 
View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/53b8bb0dfec7666f19ce991be9143d35f91acdff
You're receiving this email because of your account on gitlab.com. Manage all notifications: https://gitlab.com/-/profile/notifications | Help: https://gitlab.com/help

_______________________________________________
TikiWiki-cvs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs