[TikiWiki-commits] [Git][tikiwiki/tiki][master] [DOC] login: Missing comment from !7509 etc (thanks @luciash ; )

Jonny Bradley pushed to branch master at Tiki Wiki CMS Groupware / Tiki


Commits:
fa9d153e by jonnybradley at 2026-06-03T13:40:54+01:00
[DOC] login: Missing comment from !7509 etc (thanks @luciash ;)

- - - - -


1 changed file:

- lib/userslib.php


Changes:

=====================================
lib/userslib.php
=====================================
@@ -7335,6 +7335,8 @@ class UsersLib extends TikiLib
         list($secret, $userId) = explode('.', $cookie, 2);
         $query = 'select `userId` from `tiki_user_login_cookies` where `secret`=? and `userId`=? and `expiration` > NOW()';
 
+        // $userId here is always a string because it comes from a cookie
+        // so cast the integer value from the database to a string also to match
         if ($userId === (string) $this->getOne($query, [$secret, $userId])) {
             return $userId;
         } else {



View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/fa9d153e2f62c27c79053b791c2e61b895746222

-- 
View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/fa9d153e2f62c27c79053b791c2e61b895746222
You're receiving this email because of your account on gitlab.com. Manage all notifications: https://gitlab.com/-/profile/notifications | Help: https://gitlab.com/help

_______________________________________________
TikiWiki-cvs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs