[TikiWiki-commits] [Git][tikiwiki/tiki][30.x] [FIX] bootstrap_modal: Smarty now seems to add an extra closing double quote...

"Jonny Bradley \(@jonnybradley\) via TikiWiki-cvs" <[email protected]>
Newsgroups gmane.comp.cms.tiki.cvs
Message-ID <6a2068e99be14_3819436c3455a@gitlab-sidekiq-low-urgency-cpu-bound-v2-5b68596f44-t6r8g.mail>

Jonny Bradley pushed to branch 30.x at Tiki Wiki CMS Groupware / Tiki


Commits:
78ad9fff by Jonny Bradley at 2026-06-03T17:48:23+00:00
[FIX] bootstrap_modal: Smarty now seems to add an extra closing double quote...
---
* [FIX] bootstrap_modal: Smarty now seems to add an extra closing double quote so this extra escaped one was leading to "tag not closed" warnings

See merge request tikiwiki/tiki!10435


(cherry picked from commit 2dfbeebf9339f3a5cb5f15f38c8b20f0a36832cf)

94c4bb32 [FIX] bootstrap_modal: Smarty now seems to add an extra closing double quote...

Co-authored-by: Jonny Bradley <[email protected]>
- - - - -


1 changed file:

- lib/smarty_tiki/FunctionHandler/BootstrapModal.php


Changes:

=====================================
lib/smarty_tiki/FunctionHandler/BootstrapModal.php
=====================================
@@ -36,6 +36,6 @@ class BootstrapModal extends Base
         }
         $params['modal'] = 1;
         $href = smarty_function_service($params, $template);
-        return "$href\" data-tiki-bs-toggle=\"modal\" data-bs-backdrop=\"static\" data-bs-target=\".footer-modal.fade:not(.show):first$size\"";
+        return "$href\" data-tiki-bs-toggle=\"modal\" data-bs-backdrop=\"static\" data-bs-target=\".footer-modal.fade:not(.show):first$size";
     }
 }



View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/78ad9fff6115c1bc59f16db2e675bbb5bfd40bd5

-- 
View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/78ad9fff6115c1bc59f16db2e675bbb5bfd40bd5
You're receiving this email because of your account on gitlab.com. Manage all notifications: https://gitlab.com/-/profile/notifications | Help: https://gitlab.com/help

_______________________________________________
TikiWiki-cvs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.