[TikiWiki-commits] [Git][tikiwiki/tiki][30.x] [FIX] Tracker Controller: Update permission check for admin trackers to use...
"ushindi bienvenu \(@usbbush\) via TikiWiki-cvs" <[email protected]>
| Newsgroups | gmane.comp.cms.tiki.cvs |
|---|---|
| Message-ID | <6a2ad84259818_3819599c57010@gitlab-sidekiq-low-urgency-cpu-bound-v2-664f5d7498-8rpff.mail> |
ushindi bienvenu pushed to branch 30.x at Tiki Wiki CMS Groupware / Tiki
Commits:
48ca0258 by UshindiG at 2026-06-11T15:37:31+00:00
[FIX] Tracker Controller: Update permission check for admin trackers to use...
---
* [FIX] Tracker Controller: Update permission check for admin trackers to use...
---
* [FIX] Tracker Controller: Update permission check for admin trackers to use specific tracker permissions
See merge request tikiwiki/tiki!10235
(cherry picked from commit c916bf6ab174d8bd0975c4e874ff7fac3c748468)
See merge request tikiwiki/tiki!10496
- - - - -
1 changed file:
- lib/core/Services/Tracker/Controller.php
Changes:
=====================================
lib/core/Services/Tracker/Controller.php
=====================================
@@ -736,11 +736,6 @@ class Services_Tracker_Controller
{
// TODO : Eventually, this method should filter according to the actual permissions, but because
// it is only to be used for tracker sync at this time, admin privileges are just fine.
-
- if (! Perms::get()->admin_trackers) {
- throw new Services_Exception_Denied(tr('Reserved for tracker administrators'));
- }
-
$trackerId = $input->trackerId->int();
$offset = $input->offset->int();
$maxRecords = $input->maxRecords->int();
@@ -748,6 +743,11 @@ class Services_Tracker_Controller
$format = $input->format->word();
$modifiedSince = $input->modifiedSince->int();
+ $perms = Perms::get('tracker', $trackerId);
+ if (! $perms->admin_trackers) {
+ throw new Services_Exception_Denied(tr('Reserved for tracker administrators'));
+ }
+
$definition = Tracker_Definition::get($trackerId);
if (! $definition) {
View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/48ca025871b304e9fccf6bd1bfa3af406a7fb486
--
View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/48ca025871b304e9fccf6bd1bfa3af406a7fb486
You're receiving this email because of your account on gitlab.com. Manage all notifications: https://gitlab.com/-/profile/notifications | Help: https://gitlab.com/help
_______________________________________________
TikiWiki-cvs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs