[TikiWiki-commits] [Git][tikiwiki/tiki][master] [FIX] perms: Prevent endless perm denied redirect loop

Jonny Bradley pushed to branch master at Tiki Wiki CMS Groupware / Tiki


Commits:
49e5f018 by Jonny Bradley at 2026-06-19T12:14:16+00:00
[FIX] perms: Prevent endless perm denied redirect loop
---
* [FIX] perms: When permission is denied on a file gallery file we end up in an endless loop instead of getting redirected to tiki-login.php - seems `session_id()` can be empty when `$_SESSION` contains valid data (possibly happening since !9161?)

See merge request tikiwiki/tiki!10557

- - - - -


1 changed file:

- lib/tikiaccesslib.php


Changes:

=====================================
lib/tikiaccesslib.php
=====================================
@@ -1228,7 +1228,7 @@ class TikiAccessLib extends TikiLib
 
         if (trim($msg)) {
             $session = session_id();
-            if (empty($session)) {
+            if (empty($session) && empty($_SESSION['loginfrom'])) {
                 // Can happen if session_silent is enabled. But does any instance enable session_silent?
                 // Removing this case would allow removing the $msg parameters and just have callers using Feedback::add() before calling redirect(). Chealer 2017-08-16
                 $start = strpos($url, '?') ? '&' : '?';



View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/49e5f018e6d96159b745c9b5305b42800b6f2006

-- 
View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/49e5f018e6d96159b745c9b5305b42800b6f2006
You're receiving this email because of your account on gitlab.com. Manage all notifications: https://gitlab.com/-/profile/notifications | Help: https://gitlab.com/help

_______________________________________________
TikiWiki-cvs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs