[TikiWiki-commits] [Git][tikiwiki/tiki][30.x] [BP][FIX] sections: skip module computation until tiki-setup.php has finished

"Jonny Bradley \(@jonnybradley\) via TikiWiki-cvs" <[email protected]> Mon, 06 Jul 2026 12:04:36 +0000
Newsgroups gmane.comp.cms.tiki.cvs
Message-ID <6a4b99d4a3727_3819aa8c28165@gitlab-sidekiq-low-urgency-cpu-bound-v2-fd48bd9cc-qjm7p.mail>

Jonny Bradley pushed to branch 30.x at Tiki Wiki CMS Groupware / Tiki


Commits:
55f04510 by luci at 2026-07-06T11:56:29+00:00
[BP][FIX] sections: skip module computation until tiki-setup.php has finished
---
* [FIX] sections: skip module computation until tiki-setup.php has finished
---
The cookie consent template fetch triggers module loading before
the section is set, causing section-filtered modules to be
incorrectly rejected. Reinstates the orphaned TIKI_SETUP_FINISHED
guard from cd598936ab.


(cherry picked from commit cc03ca1d7fa9177d7c95a8bf99ebd438c6614caa)

Co-authored-by: Bernard Sfez <[email protected]>

See merge request tikiwiki/tiki!10642

- - - - -


1 changed file:

- lib/core/Tiki/Smarty/SmartyTiki.php


Changes:

=====================================
lib/core/Tiki/Smarty/SmartyTiki.php
=====================================
@@ -370,7 +370,7 @@ class SmartyTiki extends Smarty
             }
         }
 
-        if (! defined('TIKI_IN_INSTALLER') && ! defined('TIKI_IN_TEST')) {
+        if (! defined('TIKI_IN_INSTALLER') && ! defined('TIKI_IN_TEST') && defined('TIKI_SETUP_FINISHED')) {
             require_once 'tiki-modules.php';
             // Re-assign module_pref_errors after modules are loaded to capture errors from lazy rendering
             if (Perms::get()->admin) {



View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/55f045109ea39ff60127ed0f98f3aef8367f5dec

-- 
View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/55f045109ea39ff60127ed0f98f3aef8367f5dec
You're receiving this email because of your account on gitlab.com. Manage all notifications: https://gitlab.com/-/profile/notifications | Help: https://gitlab.com/help

_______________________________________________
TikiWiki-cvs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs