[TikiWiki-commits] [Git][tikiwiki/tiki][30.x] [FIX][UI] Removed obsolete page-header height rule in the FiveAlive-lite...

Gary Cunningham-Lee pushed to branch 30.x at Tiki Wiki CMS Groupware / Tiki


Commits:
ab454ad9 by Gary Cunningham-Lee at 2026-07-11T20:40:14+09:00
[FIX][UI] Removed obsolete page-header height rule in the FiveAlive-lite...
---
* [FIX][UI] Removed obsolete page-header height rule in the FiveAlive-lite...
---
* [FIX][UI] Removed obsolete page-header height rule in the FiveAlive-lite theme; removed unnecessary div class=row in the header of the admin layout; updated 'apple-mobile-web-app-capable' to 'mobile-web-app-capable', etc. in setup.php.

See merge request tikiwiki/tiki!10693


(cherry picked from commit 19adb87ae6af260f098b4b3b8e4eb6a82c4af463)

fd736b89 [FIX][UI] Removed obsolete page-header height rule in the FiveAlive-lite...

Co-authored-by: Gary Cunningham-Lee <gary_c-39LOpZwlz1/[email protected]>

See merge request tikiwiki/tiki!10695

- - - - -


4 changed files:

- lib/setup/theme.php
- templates/layouts/admin/layout_view.tpl
- themes/fivealive-lite/scss/_tiki-selectors.scss
- themes/fivealive-lite/scss/_variables.scss


Changes:

=====================================
lib/setup/theme.php
=====================================
@@ -214,8 +214,8 @@ Sections::onSectionChange(function ($section) {
         // add meta tag
         $headerlib->add_meta("theme-color", "");
         // iOS Safari
-        $headerlib->add_meta("apple-mobile-web-app-capable", "yes");
-        $headerlib->add_meta("apple-mobile-web-app-status-bar-style", "black-translucent");
+        $headerlib->add_meta("mobile-web-app-capable", "yes");
+        $headerlib->add_meta("mobile-web-app-status-bar-style", "black-translucent");
         // add jq to set content of theme-color Meta Tag to the current theme navbar color
         $headerlib->add_jq_onready($jq, 5);
     }


=====================================
templates/layouts/admin/layout_view.tpl
=====================================
@@ -14,11 +14,9 @@
         <a class="btn btn-info btn-lg skipnav" href="#col1" role="button">{tr}Skip to main content{/tr}</a>
         <div class="container{if isset($smarty.session.fullscreen) && $smarty.session.fullscreen eq 'y'}-fluid{/if} container-std">
     {if !isset($smarty.session.fullscreen) || $smarty.session.fullscreen ne 'y'}
-            <div class="row">
-                <header class="page-header w-100 navbar-{$navbar_color_variant}-parent bg-{$navbar_color_variant}-parent tiki-top-nav-{$navbar_color_variant}" id="page-header" role=banner>
-                {modulelist zone=top class="top_modules navbar-{$navbar_color_variant}-parent bg-{$navbar_color_variant}-parent navbar-{$navbar_color_variant} tiki-top-nav-{$navbar_color_variant}" heading_text='{tr}Site identity, navigation, etc.{/tr}'}
-               </header>
-            </div>
+        <header class="page-header w-100 navbar-{$navbar_color_variant}-parent bg-{$navbar_color_variant}-parent tiki-top-nav-{$navbar_color_variant}" id="page-header" role=banner>
+            {modulelist zone=top class="top_modules navbar-{$navbar_color_variant}-parent bg-{$navbar_color_variant}-parent navbar-{$navbar_color_variant} tiki-top-nav-{$navbar_color_variant}" heading_text='{tr}Site identity, navigation, etc.{/tr}'}
+        </header>
     {/if}
             <div class="row row-middle" id="row-middle">
         {modulelist zone=topbar class="topbar_modules topbar navbar-{$navbar_color_variant} bg-{$navbar_color_variant} tiki-topbar-nav-{$navbar_color_variant} w-100 mb-sm" heading_text='{tr}Navigation and related functionality and content{/tr}'}


=====================================
themes/fivealive-lite/scss/_tiki-selectors.scss
=====================================
@@ -48,11 +48,9 @@ body.fullscreen.tiki.navbar-padding {
 .layout_social .topbar_modules .sitetitle,
 .layout_social_modules .topbar_modules .sitetitle {
     font-size: 1.8rem;
-    line-height: $tiki-navbar-fixed-height;
 }
 
 .layout_social .top_modules {
-    height: $tiki-navbar-fixed-height;
      .sitelogo img {
         width: auto !important;
         margin-right: 1.5em;
@@ -69,8 +67,6 @@ body.fullscreen.tiki.navbar-padding {
         float: left;
         font-size: 1.5em;
         margin: 0 0 0 1.5em;
-        line-height: $tiki-navbar-fixed-height;
-        height: $tiki-navbar-fixed-height;
         color: #ffffff;
     }
 }


=====================================
themes/fivealive-lite/scss/_variables.scss
=====================================
@@ -112,7 +112,6 @@ $tiki-postbody-title-bg: $tiki-header_outer-bg !default;
 $tiki-postbody-title-color: #000000 !default;
 $tiki-side-column-border: none !default;
 $tiki-topbar_container-bg: $tiki-navbar-dark-navbar-nav-li-a-bg !default;
-$tiki-navbar-fixed-height: 46px !default;
 
 // Update for Smartmenus (still needed?)
 $dropdown-item: $dropdown-link-color; // !default



View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/ab454ad962fd183823cbfe996799f24422b0a216

-- 
View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/ab454ad962fd183823cbfe996799f24422b0a216
You're receiving this email because of your account on gitlab.com. Manage all notifications: https://gitlab.com/-/profile/notifications | Help: https://gitlab.com/help

_______________________________________________
TikiWiki-cvs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs