[TikiWiki-commits] [Git][tikiwiki/tiki][master] [FIX] modlib.php: set default value when invalid module rows value is returned...
"ushindi bienvenu \(@usbbush\) via TikiWiki-cvs" <[email protected]> Mon, 13 Jul 2026 13:02:15 +0000
| Newsgroups | gmane.comp.cms.tiki.cvs |
|---|---|
| Message-ID | <6a54e1d73b6b1_3819c0443897@gitlab-sidekiq-low-urgency-cpu-bound-v2-86bfb4b59d-j9g29.mail> |
ushindi bienvenu pushed to branch master at Tiki Wiki CMS Groupware / Tiki Commits: b2d286e1 by Sammy Ndabo at 2026-07-13T12:44:30+00:00 [FIX] modlib.php: set default value when invalid module rows value is returned... --- * [FIX] modules: avoid deprecated integer display width * [FIX] modules: remove unrelated userlastlogged change * [FIX] modules: set default rows value in database schema * [FIX] modlib.php: set default value when invalid module rows value is returned from database as NULL, causing the sql query built to be incomplete * [FIX] userlastlogged: Prevent the trying to access array offset on value of type null warning msg * [FIX] pluginmanager: check if array key params exist See merge request tikiwiki/tiki!10665 - - - - - 2 changed files: - db/tiki.sql - + installer/schema/20260709_fix_tiki_modules_rows_default_tiki.sql Changes: ===================================== db/tiki.sql ===================================== @@ -1837,7 +1837,7 @@ CREATE TABLE `tiki_modules` ( `type` char(1) default NULL, `title` varchar(255) default NULL, `cache_time` int(14) default NULL, - `rows` int(4) default NULL, + `rows` int NOT NULL DEFAULT 10, `params` text, `groups` text, PRIMARY KEY (`moduleId`), ===================================== installer/schema/20260709_fix_tiki_modules_rows_default_tiki.sql ===================================== @@ -0,0 +1,2 @@ +UPDATE `tiki_modules` SET `rows` = 10 WHERE `rows` IS NULL OR `rows` <= 0; +ALTER TABLE `tiki_modules` CHANGE `rows` `rows` int NOT NULL DEFAULT 10; View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/b2d286e12c467ebfcaf628ec789a3f19b9d9b303 -- View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/b2d286e12c467ebfcaf628ec789a3f19b9d9b303 You're receiving this email because of your account on gitlab.com. Manage all notifications: https://gitlab.com/-/profile/notifications | Help: https://gitlab.com/help _______________________________________________ TikiWiki-cvs mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs