[TikiWiki-commits] [Git][tikiwiki/tiki][30.x] [BP][FIX] Trackers: use rule parent defaults by render mode
"Jonny Bradley \(@jonnybradley\) via TikiWiki-cvs" <[email protected]> Sat, 18 Jul 2026 09:34:38 +0000
| Newsgroups | gmane.comp.cms.tiki.cvs |
|---|---|
| Message-ID | <6a5b48ae6c4cc_3819d13829793@gitlab-sidekiq-low-urgency-cpu-bound-v2-76655d7f68-bkc9l.mail> |
Jonny Bradley pushed to branch 30.x at Tiki Wiki CMS Groupware / Tiki Commits: 53bc690b by Jonny Bradley at 2026-07-18T09:29:37+00:00 [BP][FIX] Trackers: use rule parent defaults by render mode Blocking upgrading avan.tech to 27.x, tested by @marclaporte (and others) --- * [FIX] Trackers: use rule parent defaults by render mode --- * [FIX] Trackers: use rule parent defaults by render mode See merge request tikiwiki/tiki!10091 (cherry picked from commit 9803bdfabc13c3716196bc7180a8b42d02e27e1b) c8968da5 [FIX] Trackers: use rule parent defaults by render mode Co-authored-by: MAGENE Sem Joel <[email protected]> See merge request tikiwiki/tiki!10753 - - - - - 2 changed files: - lib/wiki-plugins/wikiplugin_tracker.php - templates/tracker/replace.tpl Changes: ===================================== lib/wiki-plugins/wikiplugin_tracker.php ===================================== @@ -657,8 +657,8 @@ function wikiplugin_tracker_info() 'rulesparent' => [ 'required' => false, 'name' => tra('Field rules parent selector'), - 'description' => tra('JQuery selector for the parent object to show or hide when executing field rules.'), - 'default' => '.tracker-field-group:first', + 'description' => tra('JQuery selector for the parent object to show or hide when executing field rules. Leave empty to use the default selector for the tracker rendering mode.'), + 'default' => '', 'advanced' => true, 'filter' => 'text', ], @@ -858,6 +858,9 @@ function wikiplugin_tracker($data, $params) $wiki = trim($wiki); } + if (empty($params['rulesparent'])) { + $params['rulesparent'] = empty($tpl) && empty($wiki) ? '.tiki-form-group:first' : '.tracker-field-group:first'; + } $fields_prefix = 'ins_'; ===================================== templates/tracker/replace.tpl ===================================== @@ -331,6 +331,9 @@ {tr}wiki:pageName for a wiki page or tpl:tplName for a template{/tr} </div> </div> + <div class="form-text"> + <p>{tr _0="<code>{ldelim}DIV(class="tracker-field-group"){rdelim}...{ldelim}DIV{rdelim}</code>"}When using field rules in a configured wiki template, wrap each label and field in the field rules parent selector. Example: %0{/tr}</p> + </div> {/accordion_group} {accordion_group title="{tr}Status{/tr}" accordion_pos=$accordion_pos} <div class="mb-3 mx-0"> View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/53bc690b296d6c938c9b94f88abf9aa6914714c6 -- View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/53bc690b296d6c938c9b94f88abf9aa6914714c6 You're receiving this email because of your account on gitlab.com. Manage all notifications: https://gitlab.com/-/profile/notifications | Help: https://gitlab.com/help _______________________________________________ TikiWiki-cvs mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs