[TikiWiki-commits] [Git][tikiwiki/tiki][30.x] [FIX] trackers: Fix user selector auto-assign value retrieval when editing...
"Jonny Bradley \(@jonnybradley\) via TikiWiki-cvs" <[email protected]> Wed, 29 Jul 2026 11:20:25 +0000
| Newsgroups | gmane.comp.cms.tiki.cvs |
|---|---|
| Message-ID | <6a69e1f967882_3819d4e4410cf@gitlab-sidekiq-low-urgency-cpu-bound-v2-678f4cb569-bkqfz.mail> |
--===============3319687341150287475== Content-Type: multipart/alternative; boundary="--==_mimepart_6a69e1f91649b_3819d4e4409f8"; charset=UTF-8 Content-Transfer-Encoding: 7bit ----==_mimepart_6a69e1f91649b_3819d4e4409f8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Jonny Bradley pushed to branch 30.x at Tiki Wiki CMS Groupware / Tiki Commits: 03e720c4 by Jonny Bradley at 2026-07-29T11:20:22+00:00 [FIX] trackers: Fix user selector auto-assign value retrieval when editing another field with what was formerly "inline editing" - when not using creator or modifier modes. Regression from !8860 (cherry picked from commit 19fe3fa613219d564bf80d00702b402ca3ebb836) Co-authored-by: jonnybradley <[email protected]> - - - - - 1 changed file: - lib/core/Tracker/Field/UserSelector.php Changes: ===================================== lib/core/Tracker/Field/UserSelector.php ===================================== @@ -293,6 +293,8 @@ class Tracker_Field_UserSelector extends \Tracker\Field\AbstractItemField implem } else { $out = $this->getValue(); } + } else { + $out = $this->getValue(); } return $out; View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/03e720c4dcb49ca4d9a5a4ab1f0d2114a7d72af5 -- View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/03e720c4dcb49ca4d9a5a4ab1f0d2114a7d72af5 You're receiving this email because of your account on gitlab.com. Manage all notifications: https://gitlab.com/-/profile/notifications | Help: https://gitlab.com/help ----==_mimepart_6a69e1f91649b_3819d4e4409f8 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www= .w3.org/TR/REC-html40/loose.dtd"> <html lang=3D"en" style=3D'--code-editor-font: var(--default-mono-font, "= GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, = Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospac= e;'> <head> <meta content=3D"text/html; charset=3Dutf-8" http-equiv=3D"Content-Type">= <title> GitLab </title> <style data-premailer=3D"ignore" type=3D"text/css"> a { color: #1068bf; } </style> <style>img { max-width: 100%; height: auto; } body { font-size: .875rem; } body { -webkit-text-shadow: hsla(0,0%,100%,.01) 0 0 1px; } body { font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Ro= boto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Colo= r Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size= : inherit; } </style> </head> <body style=3D'font-size: inherit; -webkit-text-shadow: hsla(0,0%,100%,.0= 1) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"= Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif= ,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji= ";'> <div class=3D"content"> <h3 style=3D"margin-top: 20px; margin-bottom: 10px;"> Jonny Bradley pushed to branch 30.x at <a href=3D"https://gitlab.com/tiki= wiki/tiki">Tiki Wiki CMS Groupware / Tiki</a> </h3> <h4 style=3D"margin-top: 10px; margin-bottom: 10px;"> Commits: </h4> <ul> <li> <strong style=3D"font-weight: 600;"><a href=3D"https://gitlab.com/tikiwik= i/tiki/-/commit/03e720c4dcb49ca4d9a5a4ab1f0d2114a7d72af5">03e720c4</a></s= trong> <div> <span> by Jonny Bradley </span> <i> at 2026-07-29T11:20:22+00:00 </i> </div> <pre class=3D"commit-message" style=3D'white-space: pre-wrap; display: bl= ock; font-size: 14px; color: #3a383f; position: relative; font-family: "G= itLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation M= ono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida co= nsole", monospace; font-variant-ligatures: none; word-break: break-all; w= ord-wrap: break-word; background-color: #fbfafd; border-radius: 2px; marg= in: 0; padding: 8px 12px; border: 1px solid #dcdcde;'>[FIX] trackers: Fix= user selector auto-assign value retrieval when editing another field wit= h what was formerly "inline editing" - when not using creator or modifier= modes. Regression from !8860 (cherry picked from commit 19fe3fa613219d564bf80d00702b402ca3ebb836) Co-authored-by: jonnybradley <[email protected]></pre> </li> </ul> <h4 style=3D"margin-top: 10px; margin-bottom: 10px;"> 1 changed file: </h4> <ul> <li class=3D"file-stats"> <a href=3D"#d4d3e43f26b330b6fc21da4f3b8eff72133f0fc8"> lib/core/Tracker/Field/UserSelector.php </a> </li> </ul> <h4 style=3D"margin-top: 10px; margin-bottom: 10px;"> Changes: </h4> <li id=3D"d4d3e43f26b330b6fc21da4f3b8eff72133f0fc8"> <a href=3D"https://gitlab.com/tikiwiki/tiki/-/commit/03e720c4dcb49ca4d9a5= a4ab1f0d2114a7d72af5#d4d3e43f26b330b6fc21da4f3b8eff72133f0fc8"><strong st= yle=3D"font-weight: 600;">lib/core/Tracker/Field/UserSelector.php</strong= ></a> <hr style=3D"overflow: hidden; border: 1px solid #dcdcde;"> <table class=3D"code white" style=3D"border-spacing: 0; border-collapse: = collapse; width: auto; font-family: monospace; font-size: 90%;" bgcolor=3D= "#ffffff" width=3D"100%" cellpadding=3D"0" cellspacing=3D"0"> <tr class=3D"line_holder match" style=3D"line-height: 1.6;"> <td class=3D"diff-line-num unfold js-unfold old_line" data-linenumber=3D"= 293" style=3D"width: 35px; color: rgba(5,5,6,.24); border-right-width: 1p= x; border-right-color: #ececef; border-right-style: solid; padding: inher= it;" align=3D"right" bgcolor=3D"#fbfafd">...</td> <td class=3D"diff-line-num unfold js-unfold new_line" data-linenumber=3D"= 293" style=3D"width: 35px; color: rgba(5,5,6,.24); border-right-width: 1p= x; border-right-color: #ececef; border-right-style: solid; padding: inher= it;" align=3D"right" bgcolor=3D"#fbfafd">...</td> <td class=3D"line_content match" style=3D"color: rgba(5,5,6,.24); padding= : inherit;" bgcolor=3D"#fbfafd">@@ -293,6 +293,8 @@ class Tracker_Field_U= serSelector extends \Tracker\Field\AbstractItemField implem</td> </tr> <tr class=3D"line_holder" style=3D"line-height: 1.6;"> <td class=3D"old_line diff-line-num" data-linenumber=3D"293" style=3D"wid= th: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-c= olor: #ececef; border-right-style: solid; padding: inherit;" align=3D"rig= ht" bgcolor=3D"#fbfafd"> 293 </td> <td class=3D"new_line diff-line-num" data-linenumber=3D"293" style=3D"wid= th: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-c= olor: #ececef; border-right-style: solid; padding: inherit;" align=3D"rig= ht" bgcolor=3D"#fbfafd"> 293 </td> <td class=3D"line_content" style=3D"padding: inherit;"><pre style=3D'disp= lay: block; font-size: 14px; color: #3a383f; position: relative; font-fam= ily: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liber= ation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lu= cida console", monospace; font-variant-ligatures: none; word-break: break= -all; word-wrap: break-word; background-color: inherit; border-radius: 2p= x; margin: 0; padding: 0; border: inherit solid #dcdcde;'> <span class=3D= "line" data-lang=3D"php"> <span class=3D"p">}</span> <span cla= ss=3D"k" style=3D"font-weight: 600;">else</span> <span class=3D"p">{</spa= n></span> </pre></td> </tr> <tr class=3D"line_holder" style=3D"line-height: 1.6;"> <td class=3D"old_line diff-line-num" data-linenumber=3D"294" style=3D"wid= th: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-c= olor: #ececef; border-right-style: solid; padding: inherit;" align=3D"rig= ht" bgcolor=3D"#fbfafd"> 294 </td> <td class=3D"new_line diff-line-num" data-linenumber=3D"294" style=3D"wid= th: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-c= olor: #ececef; border-right-style: solid; padding: inherit;" align=3D"rig= ht" bgcolor=3D"#fbfafd"> 294 </td> <td class=3D"line_content" style=3D"padding: inherit;"><pre style=3D'disp= lay: block; font-size: 14px; color: #3a383f; position: relative; font-fam= ily: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liber= ation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lu= cida console", monospace; font-variant-ligatures: none; word-break: break= -all; word-wrap: break-word; background-color: inherit; border-radius: 2p= x; margin: 0; padding: 0; border: inherit solid #dcdcde;'> <span class=3D= "line" data-lang=3D"php"> <span class=3D"nv" style=3D"colo= r: #008080;">$out</span> <span class=3D"o" style=3D"font-weight: 600;">=3D= </span> <span class=3D"nv" style=3D"color: #008080;">$this</span><span cl= ass=3D"o" style=3D"font-weight: 600;">-></span><span class=3D"nf" styl= e=3D"color: #990000; font-weight: 600;">getValue</span><span class=3D"p">= ();</span></span> </pre></td> </tr> <tr class=3D"line_holder" style=3D"line-height: 1.6;"> <td class=3D"old_line diff-line-num" data-linenumber=3D"295" style=3D"wid= th: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-c= olor: #ececef; border-right-style: solid; padding: inherit;" align=3D"rig= ht" bgcolor=3D"#fbfafd"> 295 </td> <td class=3D"new_line diff-line-num" data-linenumber=3D"295" style=3D"wid= th: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-c= olor: #ececef; border-right-style: solid; padding: inherit;" align=3D"rig= ht" bgcolor=3D"#fbfafd"> 295 </td> <td class=3D"line_content" style=3D"padding: inherit;"><pre style=3D'disp= lay: block; font-size: 14px; color: #3a383f; position: relative; font-fam= ily: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liber= ation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lu= cida console", monospace; font-variant-ligatures: none; word-break: break= -all; word-wrap: break-word; background-color: inherit; border-radius: 2p= x; margin: 0; padding: 0; border: inherit solid #dcdcde;'> <span class=3D= "line" data-lang=3D"php"> <span class=3D"p">}</span></span> </pre></td> </tr> <tr class=3D"line_holder new" style=3D"line-height: 1.6;"> <td class=3D"old_line diff-line-num new" data-linenumber=3D"296" style=3D= "width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-rig= ht-color: #c7f0d2; border-right-style: solid; padding: inherit;" align=3D= "right" bgcolor=3D"#ddfbe6"> = </td> <td class=3D"new_line diff-line-num new" data-linenumber=3D"296" style=3D= "width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-rig= ht-color: #c7f0d2; border-right-style: solid; padding: inherit;" align=3D= "right" bgcolor=3D"#ddfbe6"> 296 </td> <td class=3D"line_content new" style=3D"padding: inherit;" bgcolor=3D"#ec= fdf0"><pre style=3D'display: block; font-size: 14px; color: #3a383f; posi= tion: relative; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "D= ejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier = New", "andale mono", "lucida console", monospace; font-variant-ligatures:= none; word-break: break-all; word-wrap: break-word; background-color: in= herit; border-radius: 2px; margin: 0; padding: 0; border: inherit solid #= dcdcde;'>+<span class=3D"line" data-lang=3D"php"> <span class=3D"p= ">}</span> <span class=3D"k" style=3D"font-weight: 600;">else</span> <spa= n class=3D"p">{</span></span> </pre></td> </tr> <tr class=3D"line_holder new" style=3D"line-height: 1.6;"> <td class=3D"old_line diff-line-num new" data-linenumber=3D"296" style=3D= "width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-rig= ht-color: #c7f0d2; border-right-style: solid; padding: inherit;" align=3D= "right" bgcolor=3D"#ddfbe6"> = </td> <td class=3D"new_line diff-line-num new" data-linenumber=3D"297" style=3D= "width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-rig= ht-color: #c7f0d2; border-right-style: solid; padding: inherit;" align=3D= "right" bgcolor=3D"#ddfbe6"> 297 </td> <td class=3D"line_content new" style=3D"padding: inherit;" bgcolor=3D"#ec= fdf0"><pre style=3D'display: block; font-size: 14px; color: #3a383f; posi= tion: relative; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "D= ejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier = New", "andale mono", "lucida console", monospace; font-variant-ligatures:= none; word-break: break-all; word-wrap: break-word; background-color: in= herit; border-radius: 2px; margin: 0; padding: 0; border: inherit solid #= dcdcde;'>+<span class=3D"line" data-lang=3D"php"> <span class=3D= "nv" style=3D"color: #008080;">$out</span> <span class=3D"o" style=3D"fon= t-weight: 600;">=3D</span> <span class=3D"nv" style=3D"color: #008080;">$= this</span><span class=3D"o" style=3D"font-weight: 600;">-></span><spa= n class=3D"nf" style=3D"color: #990000; font-weight: 600;">getValue</span= ><span class=3D"p">();</span></span> </pre></td> </tr> <tr class=3D"line_holder" style=3D"line-height: 1.6;"> <td class=3D"old_line diff-line-num" data-linenumber=3D"296" style=3D"wid= th: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-c= olor: #ececef; border-right-style: solid; padding: inherit;" align=3D"rig= ht" bgcolor=3D"#fbfafd"> 296 </td> <td class=3D"new_line diff-line-num" data-linenumber=3D"298" style=3D"wid= th: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-c= olor: #ececef; border-right-style: solid; padding: inherit;" align=3D"rig= ht" bgcolor=3D"#fbfafd"> 298 </td> <td class=3D"line_content" style=3D"padding: inherit;"><pre style=3D'disp= lay: block; font-size: 14px; color: #3a383f; position: relative; font-fam= ily: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liber= ation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lu= cida console", monospace; font-variant-ligatures: none; word-break: break= -all; word-wrap: break-word; background-color: inherit; border-radius: 2p= x; margin: 0; padding: 0; border: inherit solid #dcdcde;'> <span class=3D= "line" data-lang=3D"php"> <span class=3D"p">}</span></span> </pre></td> </tr> <tr class=3D"line_holder" style=3D"line-height: 1.6;"> <td class=3D"old_line diff-line-num" data-linenumber=3D"297" style=3D"wid= th: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-c= olor: #ececef; border-right-style: solid; padding: inherit;" align=3D"rig= ht" bgcolor=3D"#fbfafd"> 297 </td> <td class=3D"new_line diff-line-num" data-linenumber=3D"299" style=3D"wid= th: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-c= olor: #ececef; border-right-style: solid; padding: inherit;" align=3D"rig= ht" bgcolor=3D"#fbfafd"> 299 </td> <td class=3D"line_content" style=3D"padding: inherit;"><pre style=3D'disp= lay: block; font-size: 14px; color: #3a383f; position: relative; font-fam= ily: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liber= ation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lu= cida console", monospace; font-variant-ligatures: none; word-break: break= -all; word-wrap: break-word; background-color: inherit; border-radius: 2p= x; margin: 0; padding: 0; border: inherit solid #dcdcde;'> <span class=3D= "line" data-lang=3D"php"></span> </pre></td> </tr> <tr class=3D"line_holder" style=3D"line-height: 1.6;"> <td class=3D"old_line diff-line-num" data-linenumber=3D"298" style=3D"wid= th: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-c= olor: #ececef; border-right-style: solid; padding: inherit;" align=3D"rig= ht" bgcolor=3D"#fbfafd"> 298 </td> <td class=3D"new_line diff-line-num" data-linenumber=3D"300" style=3D"wid= th: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-c= olor: #ececef; border-right-style: solid; padding: inherit;" align=3D"rig= ht" bgcolor=3D"#fbfafd"> 300 </td> <td class=3D"line_content" style=3D"padding: inherit;"><pre style=3D'disp= lay: block; font-size: 14px; color: #3a383f; position: relative; font-fam= ily: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liber= ation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lu= cida console", monospace; font-variant-ligatures: none; word-break: break= -all; word-wrap: break-word; background-color: inherit; border-radius: 2p= x; margin: 0; padding: 0; border: inherit solid #dcdcde;'> <span class=3D= "line" data-lang=3D"php"> <span class=3D"k" style=3D"font-weight: = 600;">return</span> <span class=3D"nv" style=3D"color: #008080;">$out</sp= an><span class=3D"p">;</span></span> </pre></td> </tr> </table> <br> </li> </div> <div class=3D"footer" style=3D"margin-top: 10px;"> <p style=3D"font-size: small; color: #626168;"> =E2=80=94 <br> <a href=3D"https://gitlab.com/tikiwiki/tiki/-/commit/03e720c4dcb49ca4d9a5= a4ab1f0d2114a7d72af5">View it on GitLab</a>. <br> You're receiving this email because of your account on <a target=3D"_blan= k" rel=3D"noopener noreferrer" href=3D"https://gitlab.com">gitlab.com</a>= . <a href=3D"https://gitlab.com/-/profile/notifications" target=3D"_blank= " rel=3D"noopener noreferrer" class=3D"mng-notif-link">Manage all notific= ations</a> =C2=B7 <a href=3D"https://gitlab.com/help" target=3D"_blank" r= el=3D"noopener noreferrer" class=3D"help-link">Help</a> <span style=3D"color: transparent; font-size: 0; display: none; overflow:= hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0;"> Notification message regarding https://gitlab.com/tikiwiki/tiki/-/commit/= 03e720c4dcb49ca4d9a5a4ab1f0d2114a7d72af5 at 1785324025 </span> <script type=3D"application/ld+json">{"@context":"http://schema.org","@ty= pe":"EmailMessage","action":{"@type":"ViewAction","name":"View Commit","u= rl":"https://gitlab.com/tikiwiki/tiki/-/commit/03e720c4dcb49ca4d9a5a4ab1f= 0d2114a7d72af5"}}</script> </p> </div> </body> </html> ----==_mimepart_6a69e1f91649b_3819d4e4409f8-- --===============3319687341150287475== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============3319687341150287475== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ TikiWiki-cvs mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs --===============3319687341150287475==--