Re: [Tiki-devel] Adding tr tags on forum title name

As suggested and following the guidelines I created a merge request with an option (per forum) to have the title translated (default is 'n')

https://gitlab.com/tikiwiki/tiki/-/merge_requests/689 <https://gitlab.com/tikiwiki/tiki/-/merge_requests/689>
Thanks for reviewing it.


However this require to add a column "title_is_translatable" in the "tiki-forums" table in the database something that is an inch over my self-assurance capabilities. 😂😎

I’ll be glad to have some master guidance on how to do this and complete the commit. 🙏

B


> On 27 Jan 2021, at 21:00 , luciash via TikiWiki-devel <[email protected]> wrote:
> 
> make it optional and will have no objection against this
> 
> On 26.01.2021 9:01, Bsfez Tiki via TikiWiki-devel wrote:
>> (Yes it is my Tiki leftovers day ;-) )
>> 
>> The forum title or name are not translated (no tr tags).
>> 
>> I had cases where, in a multilingual context, it was an issue.
>> * One {tr}support{/tr} forum for any languages
>> * When using "Discuss pages on forums"
>> * … (I have a few Tiki with a custom file to answer the issue while I don’t remember exact example)
>> 
>> Now, I remember they were some different view about this (Luci ?) and I prefer to ask before submitting a merge request.
>> 
>> 
>> What is the opinion on committing this to have the forum name translated ?
>> 
>> At:
>>  templates/tiki-view_forum.tpl
>> 
>> Line 4
>> -		{title help="forums" admpage="forums" url=$forum_info.forumId|sefurl:'forum'}{$forum_info.name}{/title}
>> +		{title help="forums" admpage="forums" url=$forum_info.forumId|sefurl:'forum'}{tr}{$forum_info.name}{/tr}{/title}
>> 
>> 
>> B
>> 
>> _______________________________________________
>> TikiWiki-devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
> 
> 
> _______________________________________________
> TikiWiki-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

_______________________________________________
TikiWiki-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel