Re: [Tiki-devel] [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[77782] branches/21.x

Hi Marc and all (on the dev list now)

I'm pretty sure it wasn't me (in that commit at least ;) i think the theme css files were recompiled using an out of date bootstrap and possibly other libs, so i re-did it and committed in d7ec2241.

Sadly i think 21.3 may have been released with this issue, so we should probably do 21.4 soon if that's the case? :(

Thanks for the report,

jonny



> On 1 Feb 2021, at 10:30, Jonny Bradley via Tikiwiki-cvs <[email protected]> wrote:
> 
> Hi Marc
> 
> Sorry about that, i found various things in elFinder haven't been working properly (ever) like the progress bar, and digging about in it i found this "theme.css" file that should have always been included, so i added it - sorry i didn't check cypht...
> 
> Presumably there are some conflicts in the css not being targeted enough, i'll try and investigate and work out a fix as soon as i can.
> 
> jonny
> 
> 
> 
> 
>> On 30 Jan 2021, at 21:46, [email protected] wrote:
>> 
>> My webmail's CSS was broken, and according bisection, it starts with 77782
>> 
>> Updated to revision 77781.
>> [root@avan html]# svn up -r 77782
>> Updating '.':
>> U    tiki-setup.php
>> U   .
>> Updated to revision 77782.
>> [root@avan html]# svn up -r 77781
>> Updating '.':
>> U    tiki-setup.php
>> U   .
>> Updated to revision 77781.
>> You have mail in /var/spool/mail/root
>> [root@avan html]#
>> 
>> 
>> 
>> On Mon, 25 Jan 2021 16:29:35 +0000 CVS/SVN commits information [email protected] said
>> 
>>> Revision: 77782
>>>        http://sourceforge.net/p/tikiwiki/code/77782
>>> Author:   "jonnybradley"
>>> Date:     2021-01-25 16:29:35 +0000 (Mon, 25 Jan 2021)
>>> Log Message:
>>> -----------
>>> [FIX] elfinder: Add missing theme.css (TODO add local overrides in
>>> _tiki-external_scripts_overrides.scss)
>>> (cherry picked from commit 030b2dc66affe8792d7b1e16fb01391664bd2d57)
>>> Modified Paths:
>>> --------------
>>>  branches/21.x/tiki-setup.php
>>> Property Changed:
>>> ----------------
>>>  branches/21.x/
>>> Index: branches/21.x
>>> ===================================================================
>>> --- branches/21.x	2021-01-25 16:25:31 UTC (rev 77781)
>>> +++ branches/21.x	2021-01-25 16:29:35 UTC (rev 77782)
>>> Property changes on: branches/21.x
>>> ___________________________________________________________________
>>> Deleted: subgit:lock:cfad15325f410c88feb85fa2a358e3e1f6589b92
>>> ## -1 +0,0 ##
>>> -2021-01-25T16:29:22.625
>>> \ No newline at end of property
>>> Added: subgit:lock:e6c1989f20614ec1570bcdd39f34a60efbbbd017
>>> ## -0,0 +1 ##
>>> +2021-01-25T16:29:34.481
>>> \ No newline at end of property
>>> Modified: branches/21.x/tiki-setup.php
>>> ===================================================================
>>> --- branches/21.x/tiki-setup.php	2021-01-25 16:25:31 UTC (rev 77781)
>>> +++ branches/21.x/tiki-setup.php	2021-01-25 16:29:35 UTC (rev 77782)
>>> @@ -407,6 +407,7 @@
>>> 	// see
>>> http://stackoverflow.com/questions/11174170/js-invalid-left-hand-side-expression-in-postfix-operation
>>> for more general details
>>> 	$headerlib->add_jsfile('vendor_bundled/vendor/studio-42/elfinder/js/elfinder.'
>>> . $str . '.js', true)
>>> 			->add_cssfile('vendor_bundled/vendor/studio-42/elfinder/css/elfinder.' .
>>> $str . '.css')
>>> +			->add_cssfile('vendor_bundled/vendor/studio-42/elfinder/css/theme.css')
>>> 			->add_jsfile('lib/jquery_tiki/elfinder/tiki-elfinder.js');
>>> 	$elFinderLang = str_replace(['cn', 'pt-br'], ['zh_CN', 'pt_BR'],
>>> $language);
>>> This was sent by the SourceForge.net collaborative development platform, the
>>> world's largest Open Source development site.
>>> _______________________________________________
>>> Tikiwiki-cvs mailing list
>>> [email protected]
>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>> 
>> 
>> 
>> 
>> _______________________________________________
>> Tikiwiki-cvs mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>> 
> 
> 
> 
> _______________________________________________
> Tikiwiki-cvs mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>