Re: [Tiki-devel] Long and complex string in translation files

I asked because I don’t really understand such code. ;-)

I din't formally find a bug (or bad behaviour), I found an anomaly in a translation string then I followed where it came from.

I don’t know what this does and what or how I should test it.
The correct fix mean also redo all language translation files.

In short not something I’d like to mess (and certainly not on my own) after I found a bad regression in Tiki22


B

> On 16 Feb 2021, at 12:14 , luciash via TikiWiki-devel <[email protected]> wrote:
> 
> I guess so. Try and test?
> 
> On 16.02.2021 8:25, Bsfez Tiki via TikiWiki-devel wrote:
>> Hello,
>> 
>> Checking translations on a Tiki 22 I found this string:
>> // "File Upload Error: ' . \$_FILES['passwordlist']['error']));\n\t} else {  // if file has been uploaded, and there are no errors, then index the file in the database.\n\t\t\$blackL->deletePassIndex();\n\t\t\$blackL->createPassIndex();\n\t\t\$blackL->loadPassIndex(\$_FILES['passwordlist']['tmp_name'], \$_POST['loaddata']);\n\t\tFeedback::success(tra('Uploaded file has been populated into database and indexed. Ready to generate password lists" => "File Upload Error: ' . \$_FILES['passwordlist']['error']));\n\t} else {  // if file has been uploaded, and there are no errors, then index the file in the database.\n\t\t\$blackL->deletePassIndex();\n\t\t\$blackL->createPassIndex();\n\t\t\$blackL->loadPassIndex(\$_FILES['passwordlist']['tmp_name'], \$_POST['loaddata']);\n\t\tFeedback::success(tra('Uploaded file has been populated into database and indexed. Ready to generate password lists",
>> While PHPstorm search couldn’t find the source directly it seems it comes from:
>> 
>> admin/include_login.php line 84
>> Feedback::error(tr('File Upload Error: ' . $_FILES['passwordlist']['error']));
>> 
>> The tr tags is not closed properly. Is this the correct way to fix it ?
>> Feedback::error(tr('File Upload Error: ') . $_FILES['passwordlist']['error']);
>> 
>> May it is also in 21.3 (should be an update today) ?
>> 
>> Thanks
>> B
>> 
>> 
>> 
>> _______________________________________________
>> TikiWiki-devel mailing list
>> [email protected] <mailto:[email protected]>
>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
> _______________________________________________
> TikiWiki-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

_______________________________________________
TikiWiki-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel