Re: [Tiki-devel] tikiwiki Hybridauth 50+ socnets login ready to test
aris002 via TikiWiki-devel <[email protected]>
| Newsgroups | gmane.comp.cms.tiki.devel |
|---|---|
| Message-ID | <[email protected]> |
>1. One more tiki bug? It was good idea to check that wishlist comment problem in another browser. It doesn't work with Firefox (there is no "Post new comment" button or it is not visible) but works with Chromium. In firefox i can't see/find this: <div class="submit">
<div class="buttons comment-form ">
<a class="btn btn-secondary custom-handling" href="tiki-comment-post?type=trackeritem&objectId=7729" data-target="#add-comment-zone-7729">Post new comment</a>
</div>
</div>
On Friday, 14 May 2021, 12:50:42 EEST, Jonny Bradley via TikiWiki-devel <[email protected]> wrote:
Hi Aris
> On 14 May 2021, at 10:03, aris002 via TikiWiki-devel <[email protected]> wrote:
>
> Hi, all.
>
> 1. So this is a wishlist item where i would like to add a comment but i can't.
> http://dev.tiki.org/item7729-Login-and-authentification-using-Facebook-Google-or-Email
Curious, i just commented first as me and then switched to your user here http://dev.tiki.org/item7729-Login-and-authentification-using-Facebook-Google-or-Email#threadId9040
Worked ok for me (in Safari even), anything in the javascript console when you try?
> 2. And this is a solution i have created for that list item:
> https://gitlab.com/arilect/tiki/-/commits/socnets
Nice, will try it out over the weekend...
> 3. So, the question is - what is the procedure when creating a new feature like this? Do i need to create merge request for all 13 commits or squash them into one or something else?
A good question, my feeling is to squash as it seem the MR history gets retained, even when the source branch is deleted after merging, so it keeps things tidy - what do others think?
> 4. I have tried to post a new forum topic on this but I couldn't because Tiki 'clever' software said there was no topic attached...
Definitely a bug - not so clever ;)
jonny
>
>
> Regards, Aris
>
> _______________________________________________
> TikiWiki-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
_______________________________________________
TikiWiki-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
_______________________________________________
TikiWiki-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel