[Tiki-devel] Major clean up: Convert Tiki code to align to PSR-12: Will be merged before branch of 23.x if no one objects (Spaces will replace tabs)
Marc Laporte <[email protected]>
| Newsgroups | gmane.comp.cms.tiki.devel |
|---|---|
| Message-ID | <[email protected]> |
Hello all, There is an ongoing effort to keep up with the PHP ecosystem for best practices and standards. This makes it easier for new developers and to use automated tools. Here is PSR-12: https://www.php-fig.org/psr/psr-12/ Why some others have adopted PSR-12: https://expressionengine.com/blog/expressionengine-adopts-psr-12 https://blog.quickadminpanel.com/psr-2-and-psr-12-why-we-need-standards-and-how-to-apply-them/ Of course, you can find blog posts of people that do not like PSR-12... This is our merge request to respect PSR-12 https://gitlab.com/tikiwiki/tiki/-/merge_requests/798 It now touches over 300 files. While there has been some careful review, it will likely lead to a few bugs. But these bugs will be easy/quick to fix. As of now, the merge request excludes the spaces vs tabs change, to make it easier to review. Spaces will replace tabs (as per PSR-12) in a few days. Please let us know if there is a reason not to merge this in before the branch (which was just postponed to 1 week from now). We have another windows in 6-7 months, but now is a great window of opportunity. Thanks! Marc