Re: [Tiki-devel] Major clean up: Convert Tiki code to align to PSR-12: Will be merged before branch of 23.x if no one objects (Spaces will replace tabs)
Jonny Bradley via TikiWiki-devel <[email protected]>
| Newsgroups | gmane.comp.cms.tiki.devel |
|---|---|
| Message-ID | <[email protected]> |
Thanks Marc, i can't wait, although i expect it'll take a bit of getting used to and the backports will be messy for a few versions, still worth it i think, and brings Tiki a bit more in line with the rest of the world!
In a related issue, i have started the image gallery removal process, as discussed, and have a more or less ready to merge MR here
https://gitlab.com/tikiwiki/tiki/-/merge_requests/801
(although gitlab seem to be having some sort of webpack meltdown at the moment ;)
It's another biggie!
I think it's pretty well ready but would like a second or third opinion before i merge it in... or should i just do it and then we can all test (one the pre-dog-food servers for instance)?
TIA
jonny
> On 5 Jun 2021, at 17:31, Marc Laporte <[email protected]> wrote:
>
> Hello all,
>
> There is an ongoing effort to keep up with the PHP ecosystem for best practices and standards. This makes it easier for new developers and to use automated tools.
>
> Here is PSR-12: https://www.php-fig.org/psr/psr-12/
>
> Why some others have adopted PSR-12:
> https://expressionengine.com/blog/expressionengine-adopts-psr-12
> https://blog.quickadminpanel.com/psr-2-and-psr-12-why-we-need-standards-and-how-to-apply-them/
> Of course, you can find blog posts of people that do not like PSR-12...
> This is our merge request to respect PSR-12
> https://gitlab.com/tikiwiki/tiki/-/merge_requests/798
>
> It now touches over 300 files. While there has been some careful review, it will likely lead to a few bugs. But these bugs will be easy/quick to fix.
>
> As of now, the merge request excludes the spaces vs tabs change, to make it easier to review. Spaces will replace tabs (as per PSR-12) in a few days.
>
> Please let us know if there is a reason not to merge this in before the branch (which was just postponed to 1 week from now). We have another windows in 6-7 months, but now is a great window of opportunity.
>
> Thanks!
>
> Marc
>
>
>
>
> _______________________________________________
> TikiWiki-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>