Re: [Tiki-devel] Conflict between new admin ui navbar and Bootstrap layout navbar

Thanks Gary, sounds good! 👍 

jonny

> On 24 Jul 2021, at 12:30, Gary Cunningham-Lee <[email protected]> wrote:
> 
> Hi,
> 
> I was just checking again at themes.t.o., which is on Tiki 23 now. The "Classic Bootstrap" layout puts content -- the site icon and title -- in the top zone directly, not using a module zone, and the unified admin backend horizontal menu overlaps this content. The login module is normally at the right side of the top module zone but on the admin pages it gets pushed down part way into the topbar area; I'm not sure of the details on that yet.
> 
> About the topbar, the ".topbar > * " vertical margin rule is actually just in the Bootswatch themes (I don't think the rule can be in tiki_base because some themes' nav-links are the full height of the navbar, with a background where you'd notice if there was a vertical space top and bottom.). I added that recently when I was checking for new Bootswatch themes and noticed the navbars are on their example pages are taller than the ones in the Tiki versions and I wanted to make ours more similar to the originals. I can change .topbar > * to  .topbar_modules, though, and that seems to fix the empty topbar being rendered with 1rem height.
> 
> -- Gary
> 
> 
>> On 7/19/2021 6:26 PM, Jonny Bradley via TikiWiki-devel wrote:
>> Hi Gary
>> 
>> The "magic" is in \ModLib::filter_active_module and basically checks if pref theme_unified_admin_backend is enabled, we're on tiki-admin.php, not in the new "admin" zone (and not the login box module - Luci reckoned it should be there always).
>> 
>> Aha, it's the topbar_modules zone which gets rendered even if empty...
>> 
>> It seems to be the `.topbar > *` vertical margin definitions (in all the themes) that makes that show up even if empty, could that be changed (to padding on the . topbar_modules maybe? And shouldn't that be in base_files really? ;)
>> 
>> jonny
>> 
>> 
>> 
>>>> On 19 Jul 2021, at 06:55, Gary Cunningham-Lee<[email protected]>  wrote:
>>> 
>>> Hi,
>>> 
>>> When the "Unified Admin Backend" is turned on, the horizontal navbar at the top of the page seems to occupy the same space as the still-displaying standard fixed-top navbar when the Bootstrap layout is being used. Seems like the magic that makes the other module zones, etc. disappear when the new admin ui is on should be applied to this one too, unless I'm missing something.
>>> 
>>> -- Gary
>>> 
>>> 
>>> 
>>> _______________________________________________
>>> TikiWiki-devel mailing list
>>> [email protected]
>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>>> 
>> _______________________________________________
>> TikiWiki-devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
> 
> 
> _______________________________________________
> TikiWiki-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel



_______________________________________________
TikiWiki-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel