Re: [Tiki-devel] Question about Unified Admin Backend colors

Hi Jonny,

I guess I have to make a branch to do a merge request. I've been 
committing directly from my local clone.

-- Gary


On 7/26/2021 8:09 PM, Jonny Bradley via TikiWiki-devel wrote:
> Hi Gary
>
> Shame you weren't part of the development of this, we did (well, Luci and Katy) initially started with a separate adminui theme, but i (quite strongly) thought that was too fiddly and would prevent themes from overriding and admin parts, hence adding the "feature" scss compilation mechanism in
>
>      https://gitlab.com/tikiwiki/tiki/-/commit/3b4f7940b8937044a40ab537880ee677bd9b5f9e?merge_request_iid=778
>
> We also added a new pref to chose dark or light navbars in the control panels...
>
> I don't see why themes shouldn't set colours and fonts etc for the admin area like they do for the rest (doesn't it use bootstrap classes?) and you could even add a themes/yourtheme/scss/feature/adminui.scss and compile it's own version just for that theme.
>
> Not totally sure exactly what you are proposing, but maybe do a merge request so we can have a closer look at it before committing?
>
> jonny
>
>
>
>
>
>> On 25 Jul 2021, at 09:19, Gary Cunningham-Lee <gary_c-39LOpZwlz1/[email protected]> wrote:
>>
>> Hi (especially luci, Katy, and Jonny),
>>
>> About the new Unified Admin Backend colors, I understand the thinking that there should be standard dark and light versions because they would be more familiar to people coming from other web software, etc.
>>
>> But I also like the idea of having the option of the colors (and font) being set by the theme. So maybe the default for a new installation could be a dark-background Unified Admin Backend menu as designed, but that could be changed by the site admin. To provide the styling just as the team designed it, I can make a new default admin theme for new installations using the UAB styles.
>>
>> In a local dev branch for alternative themes here, I worked out (80% done or so)having the themes style the  UAB page elements, and this was without editing any theme files so far, but just using the same method as with other components to expose the UAB selectors to the theme variables. (The color-/font-related selectors were moved from adminui.scss to tiki-selectors.scss, which each theme imports and provides values for during compiling.)
>>
>> So if it's agreeable, I can finish this up and commit it. IMO, it's nice to see the Unified Admin Backend rendered consistently with the theme, though I understand the reasoning behind having the basic dark or light style as a default.
>>
>> Thanks,
>>
>> Gary
>>
>>
>>
>>
>>
>>
>> _______________________________________________
>> TikiWiki-devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>
>
> _______________________________________________
> TikiWiki-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel