Re: [Tiki-devel] Plugin Include start and end hidden

On Mon, Oct 4, 2021 at 8:05 AM Jonny Bradley via TikiWiki-devel <
[email protected]> wrote:

> Hi Jonah
>
> I'm afraid i don't agree with your suggestion of changing the parameter
> descriptions, in my mind:
>
>   Start: This is the line before the bit i want included
>     This is the first line i want included, which comes AFTER the "start"
> line above
>     Blah blah...
>     And this line too which comes BEFORE the "stop" line below
>   Stop: And this is the line after the included part
>

It's all in what things mean to us, so I can't say my thinking is right.

To me, the thing that is supposed to be typed in is the line BEFORE the
stuff that's included.
And then at the end, we want the line that's AFTER everything that's
included.

YMMV.

It isn't very important. When I wasn't sure what the documentation meant, I
just made a wikipage 'test' that went

aaa
bbb
ccc

And another that had {include page="test" start="aaa" stop="ccc"}

and saw whether the aaa and ccc got displayed.



> > On 4 Oct 2021, at 12:21, Jonah Thomas <[email protected]> wrote:
> >
> > On Mon, Oct 4, 2021 at 3:25 AM Bernard Sfez <[email protected]> wrote:
> >> OK ok ok ;-)
> >>
> >> I created a sample to demonstrate.
> >>
> >> Interesting to note, dear Jonny, that from Tiki23 to Tiki21 (or 19)
> there was a change of behaviour with the start and stop markers.
> >> Because on Tiki23 the Start and End markers are (properly) omitted from
> being displayed. (Which solve the problems if you use recent Tiki version)
> >>
> >> Tooltip says:
> >> When only a portion of the page should be included, full text of the
> line after which inclusion should start
> >
> > Include works that way for me on V21.4
> >
> > So the documentation should change. I'm not set up to do that myself
> yet.\
> > wikiplugin_include.php should change
> >
> > 'description' => tr('When only a portion of the page should be included,
> full text of the line after which inclusion should start'),
> > to
> > 'description' => tr('When only a portion of the page should be included,
> full text of the line before which inclusion should start'),
> >
> > and
> > 'description' => tr('When only a portion of the page should be included,
> full text of the line before which inclusion should end'),
> > to
> > 'description' => tr('When only a portion of the page should be included,
> full text of the line after which inclusion should end'),
> >
> > 'start' => [
> > 'required' => false,
> > 'name' => tr('Start'),
> > 'description' => tr('When only a portion of the page should be included,
> full text of the line before which
> > inclusion should start'),
> > 'since' => '1',
> > 'default' => '',
> > ],
> > 'stop' => [
> > 'required' => false,
> > 'name' => tr('Stop'),
> > 'description' => tr('When only a portion of the page should be included,
> full text of the line after which
> > inclusion should end'),
> > 'since' => '1',
> > 'default' => '',
> > ],
> >
> >
> >> And as we can see:
> http://bsfez-11581-7848.show2.tikiwiki.org/tiki-index.php?page=HomePage
> >> 1.1.1 using plain text is fine (the markers are hidden and the correct
> text is included)
> >>
> >> 1.1.2, 1.1.3 and 1.1.4 failed
> >>
> >> 1.1.5 using the hc tag (HTML Comment) are working too.
> >>
> >> So we have 2 good solutions with Tiki23 and a possible fallback for
> oldest version (not sure when)
> >>
> >> Bernard
> >>
> >> PS: Note that for some reason the numbering function failed for the
> first heading 1.1.1.
> >>
> >> --
> > Jonah Thomas
> >
> > We are limited, but the limits aren't where we think they are. We find
> them only by exceeding them.
> >
> >
> >
> > _______________________________________________
> > TikiWiki-devel mailing list
> > [email protected]
> > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>
>
>
> _______________________________________________
> TikiWiki-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>


-- 
Jonah Thomas

We are limited, but the limits aren't where we think they are. We find them
only by exceeding them.

_______________________________________________
TikiWiki-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel