Re: [Tiki-devel] Calendar weekly recurrences enhancement
Jonny Bradley via TikiWiki-devel <[email protected]>
| Newsgroups | gmane.comp.cms.tiki.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi Victor Thanks for the feedback - i did wrestle with whether to use upper case day abbreviations for compatibility with CALDAV, or capitalised to keep it as it was in tiki before, or to just capitalise/ucwords then when needed - i guess adopting the CALAV convention makes most sense in the long term... By the way, i uncovered nasty timezone thing on recurring all-day events, more on that later when i give in... ;) jonny > On 5 Oct 2021, at 13:30, Victor Emanouilov via TikiWiki-devel <[email protected]> wrote: > > Hi Jonny, > > I think the MR is quite good to merge. Didn't find anything suspicious. Just a small note that rfc 5545 lists the weekdays all upper case and even thought it specifies that parameter value list is case-insensitive, I think we should keep upper case letters for the days to maintain client compatibility. Note that CALDAV integration allows us to export events via CALDAV protocol to other calendaring client apps and how do each of them interpret rfc 5545 is a vague topic. > > In short, I think whenever you use BYDAY=-days-coming-from-tiki- you should uppercase your two-letter day abbreviations as they are stored as mixed case in Tiki. > > Regards, > Victor > > On 10/4/21 7:14 PM, Jonny Bradley via TikiWiki-devel wrote: >> Hi all, probably Victor mainly i think >> >> I've got a branch that seems to work and an MR here to allow weekly recurrences to happen on multiple days of the week (i.e. every weekend, or Mondays, Wednesdays and Fridays for instance) >> >> https://gitlab.com/tikiwiki/tiki/-/merge_requests/922 >> >> I'd like to merge (and backport to 23.x) it soon so would appreciate a little testing and checking over (please). Especially concerning the CalDAV/SabreDAV implications, hence "calling Victor" :) >> >> Seems to work ok for me, it does include a little database upgrade so watch out for that - i'll continue testing here so let me know if you spot anything wrong. >> >> Thanks! >> >> jonny >> >> >> >> _______________________________________________ >> TikiWiki-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel > > > _______________________________________________ > TikiWiki-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel >