[Tiki-devel] Fwd: Tiki | Failed pipeline for master | 7fe28a3f

Hi all

Oops, sorry, i borked the tests! :o

I removed the references from tiki.sql for new installs but deliberately didn't write an updater script to do the same on upgrades in case the image gallery migration went wrong, for instance.

How should we handle this? Do i need to add some exceptions to the compare script, presumably in doc/devtools/check_schema_upgrade.php somewhere (which i've never managed to get to work locally in the past)...

Ah, presumably i should add all this in \TikiDevTools\CheckSchemaUpgrade::scrubDbCleanThingsThatShouldChange?

Or should i add an upgrade script to actually remove that data?

TIA

jonny





> Begin forwarded message:
> 
> From: GitLab <[email protected]>
> Subject: Tiki | Failed pipeline for master | 7fe28a3f
> Date: 20 October 2021 at 16:25:44 BST
> Reply-To: GitLab <[email protected]>
> 
> 
> 	Pipeline #392074467 has failed!
>  
> Project	Tiki Wiki CMS Groupware / Tiki
> Branch	
> 	master
> Commit	
> 	7fe28a3f
> [KIL] imagegallery: Even more left overs remove...
> Commit Author	
> 	Jonny Bradley
>  
> Pipeline #392074467 triggered by		Jonny Bradley
> had 14 failed jobs.
> Failed jobs
> 	tiki-check
> check-directories
> 	lint
> smarty-lint
> 	tiki-check
> db-upgrade-18-lts-myisam
> 	lint
> phpcs
> 	tiki-check
> db-upgrade-19
> 	tiki-check
> db-upgrade-18-lts
> 	tiki-check
> db-upgrade-20
> 	tiki-check
> db-upgrade-21
> 	tiki-check
> sql-engine-conversion
> 	tiki-check
> db-upgrade-22
> 	tiki-check
> translation-standards
> 	tiki-check
> db-upgrade-22-mysql8
> 	tiki-check
> db-upgrade-21-mysql8
> 	tiki-check
> db-upgrade-20-mysql8
> 
> You're receiving this email because of your account on gitlab.com. Manage all notifications · Help



_______________________________________________
TikiWiki-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel