Re: [Tiki-devel] Tiki | Failed pipeline for master | 7fe28a3f

Hi all CI fans! :)

I finally got the database pipeline failures i caused during part 94 of the Image Galleries removal fixed, probably should document all the stuff you need to do now if changing the database like that one day (but don't have time ;)

Meanwhile, a couple of unit tests seem to be failing now which i don't think are related to anything i've done - e.g.

    https://gitlab.com/tikiwiki/tiki/-/jobs/1743413504

@Victor could you take a look please? I think you did some changes to tests and permissions things recently didn't you? Seems to be something to do with indexing?

jonny




> On 25 Oct 2021, at 17:59, Jonny Bradley via TikiWiki-devel <[email protected]> wrote:
> 
> Hi all again, and again probably mostly/only Ricardo...
> 
> Sorry, i'm stuck now. I've managed to get it down to a single error (woo) but i can't now work out how to fix it.
> 
> The remaining error on all upgrade db jobs) is:
> 
>> == Result of the db Analysis - missing statements ==
>> DELETE FROM `tiki_menu_options` WHERE `optionId` = '192';
> 
> so one item is getting left over as there should be 191 of them, but how do i find out which one? I downloaded the artefacts from most of them (e.g. https://gitlab.com/tikiwiki/tiki/-/jobs/1713115602/artifacts/download?file_type=archive) but that only has the first table in it :(
> 
> Am i missing something?
> 
> TIA and apologies to all again
> 
> jonny
> 
> 
> 
> 
> 
>> On 20 Oct 2021, at 17:18, Jonny Bradley via TikiWiki-devel <[email protected]> wrote:
>> 
>> Hi all again (Ricardo really i guess ;)
>> 
>> Have added a hopeful fix in 
>> 
>>   https://gitlab.com/tikiwiki/tiki/-/commit/8bb38c69
>> 
>> Pipeline running, fingers crossed... well, still fails but with fewer errors, so i must be on the right track! 🤓
>> 
>> I don't completely understand the code that is supposed "to account for the case where an old entry is removed" in tiki_menu_options and tiki_actionlog_conf tables, presumably this is to renumber the auto-increment columns so they match? Do i need to add the same thing for tiki_live_support_modules do you think?
>> 
>> But why is there still one error on tiki_menu_options i wonder?
>> 
>> Out of time for this now, will try again more tomorrow...
>> 
>> jonny
>> 
>> 
>> 
>>> On 20 Oct 2021, at 16:37, Jonny Bradley via TikiWiki-devel <[email protected]> wrote:
>>> 
>>> Hi all
>>> 
>>> Oops, sorry, i borked the tests! :o
>>> 
>>> I removed the references from tiki.sql for new installs but deliberately didn't write an updater script to do the same on upgrades in case the image gallery migration went wrong, for instance.
>>> 
>>> How should we handle this? Do i need to add some exceptions to the compare script, presumably in doc/devtools/check_schema_upgrade.php somewhere (which i've never managed to get to work locally in the past)...
>>> 
>>> Ah, presumably i should add all this in \TikiDevTools\CheckSchemaUpgrade::scrubDbCleanThingsThatShouldChange?
>>> 
>>> Or should i add an upgrade script to actually remove that data?
>>> 
>>> TIA
>>> 
>>> jonny
>>> 
>>> 
>>> 
>>> 
>>> 
>>>> Begin forwarded message:
>>>> 
>>>> From: GitLab <[email protected]>
>>>> Subject: Tiki | Failed pipeline for master | 7fe28a3f
>>>> Date: 20 October 2021 at 16:25:44 BST
>>>> Reply-To: GitLab <[email protected]>
>>>> 
>>>> 
>>>> 	Pipeline #392074467 has failed!
>>>> 
>>>> Project	Tiki Wiki CMS Groupware / Tiki
>>>> Branch	
>>>> 	master
>>>> Commit	
>>>> 	7fe28a3f
>>>> [KIL] imagegallery: Even more left overs remove...
>>>> Commit Author	
>>>> 	Jonny Bradley
>>>> 
>>>> Pipeline #392074467 triggered by		Jonny Bradley
>>>> had 14 failed jobs.
>>>> Failed jobs
>>>> 	tiki-check
>>>> check-directories
>>>> 	lint
>>>> smarty-lint
>>>> 	tiki-check
>>>> db-upgrade-18-lts-myisam
>>>> 	lint
>>>> phpcs
>>>> 	tiki-check
>>>> db-upgrade-19
>>>> 	tiki-check
>>>> db-upgrade-18-lts
>>>> 	tiki-check
>>>> db-upgrade-20
>>>> 	tiki-check
>>>> db-upgrade-21
>>>> 	tiki-check
>>>> sql-engine-conversion
>>>> 	tiki-check
>>>> db-upgrade-22
>>>> 	tiki-check
>>>> translation-standards
>>>> 	tiki-check
>>>> db-upgrade-22-mysql8
>>>> 	tiki-check
>>>> db-upgrade-21-mysql8
>>>> 	tiki-check
>>>> db-upgrade-20-mysql8
>>>> 
>>>> You're receiving this email because of your account on gitlab.com. Manage all notifications · Help
>>> 
>>> 
>>> 
>>> _______________________________________________
>>> TikiWiki-devel mailing list
>>> [email protected]
>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>> 
>> 
>> 
>> _______________________________________________
>> TikiWiki-devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
> 
> 
> 
> _______________________________________________
> TikiWiki-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel



_______________________________________________
TikiWiki-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel