Re: [Tiki-devel] Layout templates are missing xl display classes
Jonny Bradley via TikiWiki-devel <[email protected]>
| Newsgroups | gmane.comp.cms.tiki.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi Gary Yes please, add this to master & 24.x - i don't think the side columns need to be wider than necessary so i'd guess col-xl-1 for each should be fine, no? Assuming i've understood correctly? So do we need to change or remove the "fixed width" prefs (feature_fixed_width and layout_fixed_width) now? It currently defaults to 1170px but does that correspond to XL or LG size? Thanks! jonny > On 31 Jan 2022, at 08:16, Gary Cunningham-Lee <gary_c-39LOpZwlz1/[email protected]> wrote: > > Hi, > > This is kinda embarrassing, but I just realized we didn't add Bootstrap .col-xl-* grid classes in the layout templates when they were added in Bootstrap (unless they were added and then removed in some regression). In layout_view.tpl, there should be classes for .col2 and .col3 to be col-xl-2 or col-xl-1 (either 16.6% or 8.3%), depending on how wide we want them to be (narrow or really narrow), and for .col1 to have col-xl-10 or col-xl-11 (wide or really wide). These should be added to the three layout templates. > > My display here is 2560 x 1440 and either of those widths seems ok, that is, the normal menu content, etc. seem to display without extra line wraps. I didn't notice anything wrong probably because I usually have 150% scaling on here due to it being a 14-inch screen, but I checked things out more closely when a use case question came up about having a narrower left column in large displays. > > So the layout templates should be updated, and I'm assuming both in branch 24 and trunk, right? > > And what is the consensus regarding the grid class/width (directed to people with wide displays, I imagine) -- col-xl-1 or col-xl-2? > > -- Gary > > > > _______________________________________________ > TikiWiki-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel