Re: [Tiki-devel] bootstrap 5

Thanks Victor for pointing that out.

For jQuery compatibility we could just keep the data-* attributes (i.e. 
not remove them) while adding data-bs-* where needed only? I know it 
sounds a bit stupid (aka duplication) but better than rewriting all the 
jQuery code maybe?

luci


Dne 03.05.2022 v 11:02 Victor Emanouilov via TikiWiki-devel napsal(a):
> Jonny, Gary, thanks for this!
>
> I noticed a couple of bugs but fixed those, so no worries. Just wanted 
> to mention that data-* attributes are sometimes used in jquery code, 
> so changing these to data-bs-* breaks the JS code. I think we should 
> really only change data-* to data-bs-* attributes for the ones that BS 
> uses, not for all of them...
>
> Regards,
> Victor
>
> On 4/11/22 9:21 PM, Jonny Bradley via TikiWiki-devel wrote:
>> Hi again
>>
>> Ok, i just merged it in 
>> https://gitlab.com/tikiwiki/tiki/-/commit/1133c167 - i thought it had 
>> updated what was going to be the commit message but i did it wrong 
>> thing i think, it should have been:
>>
>> [ENH] Update Bootstrap to v5 - many templates and js files affected, 
>> please report any regressions
>>
>> Sorry about that...
>>
>> Don't forget to update your composer (install) and clear your caches, 
>> setup.sh should do the server side of it, browser caches seem to need 
>> clearing sometimes too.
>>
>> Hope that's all ok, thanks to Gary again for doing most of it!
>>
>> jonny
>>
>>
>>
>>
>>> On 11 Apr 2022, at 17:43, Jonny Bradley via TikiWiki-devel 
>>> <[email protected]> wrote:
>>>
>>> Hi all again
>>>
>>> So, some hours later... i've fixed (mostly) the issues with tooltips 
>>> i think, and everything now functions mostly ok again in 
>>> https://gitlab.com/tikiwiki/tiki/-/tree/tiki-bootstrap5 - and then 
>>> i'managed to resolve the conflicts and rebased it, and i'd quite 
>>> like not to do that again (!) so i'll merge this in shortly (in an 
>>> hour or two), hopefully before more conflicts arrive, unless anyone 
>>> says not to.
>>>
>>> So speak now or...
>>>
>>> jb :)
>>>
>>>
>>>> On 11 Apr 2022, at 11:12, Jonny Bradley via TikiWiki-devel 
>>>> <[email protected]> wrote:
>>>>
>>>> Hi all
>>>>
>>>> As planned some time ago and announced on 
>>>> https://dev.tiki.org/tiki25 Gary (mainly) has been toiling away on 
>>>> the tiki-bootstrap5 branch on gitlab and an MR here 
>>>> https://gitlab.com/tikiwiki/tiki/-/merge_requests/1405
>>>>
>>>> We currently have 777 files modified there so almost everything 
>>>> changed in trunk is causing a conflict now, so we need to merge it 
>>>> back into trunk soon!
>>>>
>>>> I have one more bug with the delay on our tooltips (created by 
>>>> smarty_function_popup()) but after that i'll just merge it in, 
>>>> possibly/hopefully later today... hope that's ok!
>>>>
>>>> You will need to run setup.sh to get the new packages and clear 
>>>> caches etc after you do git pull (or svn up ;)
>>>>
>>>> There is likely still to be some minor breakages and cosmetic 
>>>> issues but we will clean anything up when it's merged. Do let me or 
>>>> Gary know if something's broken (that wasn't with bs4).
>>>>
>>>> Thanks
>>>>
>>>> jonny
>>>>
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> TikiWiki-devel mailing list
>>>> [email protected]
>>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>>>>
>>>
>>>
>>> _______________________________________________
>>> TikiWiki-devel mailing list
>>> [email protected]
>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>>>
>>
>>
>> _______________________________________________
>> TikiWiki-devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>
>
> _______________________________________________
> TikiWiki-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel