Re: [Tiki-devel] Tracker status; changing status permission allows group to change item status BUT only admin can select and change (or remove) several items together

Hi Bernard

Sounds reasonable to me, but i would suggest doing the logic once in php, and then also only show the actions available to the current user, admin or not - would be cleaner i think.

jonny



> On 14 Sep 2022, at 16:18, Bernard Sfez via TikiWiki-devel <[email protected]> wrote:
> 
> Hello,
> 
> In tracker beside admin or beside assigning tiki_p_admin_trackers you can allow any other group members to see and edit tracker item content and status.
> 
> This is working fine individually only when editing a single item a user in a group with right permission can set the status of an item.
> 
> 
> However on the items tracker view the multi-select checkboxes and the "action to be performed with checked” dropdown are shown ONLY if the user has tiki_p_admin_trackers permission.
> 
> At : templates/tiki-view_tracker.tpl
> 
> Line 180 (there is a typo in code)
> {if $tiki_p_admin_trackers eq 'y'}
>     <th width="15">
>         {select_all checkbox_names='action[]'}
>     </th>
> {/if}
> 
> Line 232
> 
> {if $tiki_p_admin_trackers eq 'y'}
>     <td class="checkbox-cell">
>         <div class="form-check">
>             <input type="checkbox" class="form-check-input" name="action[]" value='{$items[user].itemId}'>
>         </div>
>     </td>
> {/if}
> 
> Line 332
> 
> {if $tiki_p_admin_trackers eq 'y'}
>     <div class="form-group row">
>         <div class="input-group min-width-customized">
>             <option value="no_action" selected="selected">
>                 {tr}Select the action to be performed with checked{/tr}…
> ...
> {/if}
> 
> Seems that only the status checkboxes display and mass action have such condition.
> 
> Wouldn’t it make sense that a user with permission to change status or delete items can do this individually (one item at the time) BUT ALSO selecting several items together ?
> 
> 
> May be using something like:
> {if $tiki_p_admin_trackers eq 'y' or ($tiki_p_remove_tracker_items eq 'y' and $items[user].status ne 'p' and $items[user].status ne 'c') or ($tiki_p_remove_tracker_items_pending eq 'y' and $items[user].status eq 'p') or ($tiki_p_remove_tracker_items_closed eq 'y' and $items[user].status eq 'c')}
> 
> What people think ?
> 
> Bernard
> 
> 
> _______________________________________________
> TikiWiki-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel



_______________________________________________
TikiWiki-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel