Re: [Tiki-devel] Pipeline failures

Merge request for fixing the issues with tiki_actionlog_conf ->
https://gitlab.com/tikiwiki/tiki/-/merge_requests/1935

DB Upgrade checks are now green again!

Ricardo

On Wed, Nov 2, 2022 at 7:35 PM Ricardo Melo <[email protected]> wrote:

> The issue is that you have named the index in 2 different ways, one in
> tiki.sql and a different one in the patch:
>
> tiki.sql:
> https://gitlab.com/tikiwiki/tiki/-/commit/dd15c7947834d78ec0e006f8a44e36858254f8f7#4d0f22aada9c8125cedc6ea8704220939fbb76a3_983_984
> KEY `galleryIdAndFilename` (`galleryId`, `filename`),
>
> installer/schema/20221024_add_indexes_to_file_galleries_tiki.sql:
> https://gitlab.com/tikiwiki/tiki/-/commit/dd15c7947834d78ec0e006f8a44e36858254f8f7#abaf169bdc889614bfbd0ed1e6aab904143d9d9a_0_3
> ALTER TABLE `tiki_files` ADD INDEX `galleryIdAndPath` (`galleryId`, `path`
> (191));
>
> So, updating the DB and fresh DB install does not generate the same result.
>
> This code was from master - so there was a reference to galleryId
> AndFilename
>
> The other issue ( until we stop supporting officially mysql 5.6) is that
> the max key size is 767, galleryId is already 14 bytes, so the max you can
> set for path is (767-14)/4 = 188
>
> Since it is recently in master I've updated the db/patch directly instead
> of creating a migration. ->
> https://gitlab.com/tikiwiki/tiki/-/merge_requests/1934 and is already
> merged to master.
>
> Regarding caching, the DBs in
> https://gitlab.com/tikiwiki/tikiwiki-ci-databases where generated from a
> clean install from that specific branch at that time - that means that we
> download a clean DB and then we try the upgrade on top and compare with the
> full db import.
>
> I'll have a look at the other issues with the DB with tiki_actionlog_conf
> now.
>
> Cheers,
> Ricardo
>
> On Fri, Oct 28, 2022 at 11:26 AM Jonny Bradley via TikiWiki-devel <
> [email protected]> wrote:
>
>> Hi Victor
>>
>> Hmm, curious, i confirm no sign of galleryIdAndFilename in trunk/master
>> now, so not sure where that's coming from. Seems odd if it doesn't use the
>> up to date files, it certainly looks like it's doing that somehow...
>>
>> I checked the artefacts from the most recently failed test and there seem
>> to be even more diffs now between new and old, so maybe the script has gone
>> haywire for some reason?
>>
>> Sorry, beyond me, @Xorti, are you around?
>>
>> jonny
>>
>>
>>
>> > On 27 Oct 2022, at 18:12, Victor Emanouilov <[email protected]> wrote:
>> >
>> > Yes, `galleryIdAndFilename` was an intermediate key I used but then
>> fell back to path as it can contain a more detailed information for the
>> file and also has greater storage. So, I am not sure why
>> galleryIdAndFilename is at all there since it isn't in 22, nor it is in
>> master... only reason I can see is some type of caching which seems that
>> pipeline needs fixing to not cache that aggressively maybe?
>> >
>> > Regards,
>> > Victor
>> >
>> > On 10/26/22 4:16 PM, Jonny Bradley wrote:
>> >> Hmm, those can be chewy those ones!
>> >>
>> >> At least the artefacts download works, and doing a file compare i see
>> tiki old.sql has
>> >>
>> >>   KEY `hits` (`hits`),
>> >>   KEY `galleryIdAndPath` (`galleryId`,`path`(191)),
>> >>   FULLTEXT KEY `ft` (`name`,`description`,`search_data`,`filename`)
>> >>
>> >> but tiki new.sql has
>> >>
>> >>   KEY `galleryIdAndFilename` (`galleryId`,`filename`),
>> >>   KEY `hits` (`hits`),
>> >>   FULLTEXT KEY `ft` (`name`,`description`,`search_data`,`filename`)
>> >>
>> >> (so galleryIdAndFilename is before hits in the new one and after in
>> the old)
>> >>
>> >> So maybe fixing that will do the trick - there are several other
>> differences in action log and prefs, but maybe the test magic ignores them?
>> >>
>> >> HTH
>> >>
>> >> jb
>> >>
>> >>
>> >>
>> >>
>> >>> On 26 Oct 2022, at 12:54, Victor Emanouilov via TikiWiki-devel <
>> [email protected]> wrote:
>> >>>
>> >>> Hi Jorge, Ricardo,
>> >>>
>> >>> Not sure why this pipiline fails:
>> >>>
>> >>> https://gitlab.com/tikiwiki/tiki/-/pipelines/677512642
>> >>>
>> >>> For example, this job:
>> >>>
>> >>> https://gitlab.com/tikiwiki/tiki/-/jobs/3230021653
>> >>>
>> >>> I added some schema migrations but incrementally in a draft MR
>> (changing the migrations from time to time as the MR evolved and I didn't
>> want to push 5-10 migrations for one and the same thing). I think the
>> pipeline uses a cache folder that needs cleaning as it keeps track of an
>> old upgrade migration that is no longer part of the code.... can you check
>> and let me know if it needs fixing on the docker side or we need to do
>> anything with the Tiki code?
>> >>>
>> >>> Thanks,
>> >>> Victor
>> >>>
>> >>>
>> >>>
>> >>> _______________________________________________
>> >>> TikiWiki-devel mailing list
>> >>> [email protected]
>> >>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>> >>>
>> >
>>
>>
>>
>> _______________________________________________
>> TikiWiki-devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>>
>

_______________________________________________
TikiWiki-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel