Re: [Tiki-devel] Menu arrows and CSS menu Superfish oddity

Hi Gary,

Thank you for your detailed explanations and sorry for my poor explanation of the issue I see in my previous email. 🙏

> I don't see "Superfish" on that page in branch 25


It is at the bottom of the page under “Removed”.
I added 

> Smartmenus has equivalent arrows.

I understand that.


>  Did you activate Smartmenus?

Yes, and it doesn’t work unless specific conditions. (See below)


My point is that someone upgrading his tiki regularly will get to Tiki24 seeing arrows on a big menu with this settings:



On upgrade from Tiki25 and up the arrow won’t be displayed anymore (change of behavior) and nothing to help the admin will be available.
Not on the preferences page tiki-admin.php?page=general#contentadmin_general-3
Not on the module menu settings.




Why I wrote above specific conditions ?
Because this work IF on the module bootstrap menu was set to “Yes”.
If it was set to “No” (and CSS menu to “yes”) enabling SmartMenus  has for effect to keep the menu fully open in vertical and it ran over all the content and nothing is accessible, broking the Tiki.

If you fix the issue by enabling the Bootstrap menu option and disabling the CSS menu option the menu is back with arrows.
The design however is tinier as it was (little line-height value and smaller font)



So I suggest we find ways to help people to figure what to do on upgrade.

No misunderstanding please, I’m not blaming anyone.
With what was changed, Tiki25 is very solid (I’ve upgraded most of my site 😃) and I love it.
But in a year or two, people upgrading will get to that point…

—

As a start I added some informations at :
https://doc.tiki.org/tiki25#Removed
And https://doc.tiki.org/Menu

But I think that having some help on tooltip or something to set automatically preferences to correct the change off behavior (and avoid to have the Tiki broken) will be great.

Bernard

---

PS: I see now there is an error on the preferences page

















> On 22 Jan 2023, at 15:48, Gary Cunningham-Lee <gary_c-39LOpZwlz1/[email protected]> wrote:
> 
> Hi,
> 
> I don't see "Superfish" on that page in branch 25, and it doesn't turn up in an admin options search. Can you give more info about where you see this? (I do see "Preference feature_cssmenus is not defined" in the "Menus" section under the "Navigation" tab. This should have been removed as the feature is now gone.)
> 
> Smartmenus, which was added to replace Superfish menus, supports multi-level menus, not just the two levels that Bootstrap supports by default. So if you activate Smartmenus, you'll get support for the lower levels, and there will be arrows indicating the presence of a dropdown where appropriate, like in vertical menus or lower-level sections of horizontal menus. I'm not sure what you mean exactly by left or right arrows being removed. Smartmenus has equivalent arrows. Did you activate Smartmenus?
> 
> (The system menu in a new Tiki install's left column erroneously has a "type=horiz" parameter so if anyone trying out Smartmenus in a new installation will need to correct this at tiki-admin_modules.php., until it's fixed in the code.)
> 
> -- Gary
> 
> 
> On 1/22/2023 10:17 PM, Bernard Sfez via TikiWiki-devel wrote:
>> Hello,
>> 
>> Before Tiki25 Superfish/Suckerfish was removed, as it is superseded by Smartmenus - see https://doc.tiki.org/tiki25
>> 
>> The option "Superfish“ is still there at tiki-admin.php?page=general with a warning. (This feature will be removed after Tiki23, use Smart Menus instead)
>> 
>> If you have a menu with sub items where left (or right) arrows are displayed, disabling this option will remove the arrows.
>> 
>> I suppose that, as the Superfish code has been removed, there is still something that allow the arrow-sf to be used or not.
>> 
>> Can’t we find a way preserve arrow ? (Preference menu, submenu arrow)
>> Or something more need to be cleaned ?
>> 
>> Bernard
>> 
>> 
>> 
>> 
>> 
>> _______________________________________________
>> TikiWiki-devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
> 
> 
> _______________________________________________
> TikiWiki-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

_______________________________________________
TikiWiki-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel