[Tiki-devel] User tracker sync issues

Hi all,

We (me and Jonny) debugged recently an issue with user tracker and sync 
preferences silently updating currently logged user's realname/email (or 
other preference) even though currently logged user with admin 
privileges edits another user's tracker item. Has anybody experienced 
something similar?

I prepared a MR to fix:

https://gitlab.com/tikiwiki/tiki/-/merge_requests/2266

If anybody has a quick way to test this on their Tiki set up with user 
tracker syncing (preferences: user_trackersync_trackers, 
user_trackersync_realname and UserPreference tracker field) it will be 
great as we don't want to introduce regressions! This fix needs 
backporting to Tiki 18.

In essence, we are changing this:

- real name and other preferences (including email) is only changed if 
the syncing tracker has a user selector tracker field that is set to 
Autoassign = 1 OR Item owner = 1 - we consider only these 2 fields as 
the source of truth for which user is the associated user to the tracker 
item

- we no longer fall back to default currently logged user to sync his 
preferences when there is no such user tracker field. Our immediate use 
case was having a user tracker with user selector field not set to 
autoassign - that's normal as you don't always want to autoassign to 
creator (especially when admin is maintaining this tracker). This led to 
admin user changing other user's tracker items to accidentally changing 
his own email and user preferences (e.g. real name).

Thanks for any feedback!

Regards,
Victor