Re: [Tiki-devel] phpcs code sniffing
Jonny Bradley via TikiWiki-devel <[email protected]>
| Newsgroups | gmane.comp.cms.tiki.devel |
|---|---|
| Message-ID | <[email protected]> |
> On 3 Apr 2023, at 18:38, Benoit Grégoire <[email protected]> wrote: > > On vendredi 31 mars 2023 07 h 58 min 16 s EDT Jonny Bradley via TikiWiki-devel wrote: >> > Hi all, this is for Benoit mostly i think (hope you're here ;) >> > >> > I saw a week or two ago you did some refactoring on the tracker field class >> > names (thanks!) and it involved this file >> > doc/devtools/codesniffer/standards/TikiIgnore/ignore_list.json which i was >> > unaware of. >> > >> > In my long running calendar revamp branch >> > https://gitlab.com/jonnybradley/tiki/-/tree/calendar-revamp-2 it seems i >> > had broken quite a few new tests, and the only way i found to fix them was >> > by regenerating that file, in this commit: >> > >> > https://gitlab.com/tikiwiki/tiki/-/merge_requests/2249/diffs?commit_id=7964a >> > bf7cebb47ed540430790e42bf4793870f1b >> > >> > There are a lot of changes in the diff, so hard to track visually, but will >> > this have undone anything you or anyone else did involving it? > > Ah! I, on the other hand, was unaware of doc/devtools/codesniffer/standards/TikiIgnore/generate_ignore_list.php, which was only added in january of this year. It seems I and 3 other people have been editing that file manually since ;) > > I checked the two files with meld, and it seems you: > - didn't break anyone's work Phew > - did the correct thing regenerating ignore.json with the tool. Woo hoo, was just a fluke :p So we should probably regenerate the file in trunk/master/main and then i'll untangle the conflict in my calendar branch by doing it again there - sounds like a plan? > It's too bad the ignore.json file is json, and we can't put a comment at the top. Indeed, isn't there a more modern version of json that allows that? Yes, https://json5.org/ but presumably not an option in this case... > I documented a little at https://dev.tiki.org/PHP-Code-Sniffer, but it's not ideal. Great, thanks Benoit - when i manage to get phpstorm to use it i'll try and add a little doc for that too... one day (not today sadly! ;) jonny > -- > Benoit Grégoire _______________________________________________ TikiWiki-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel