Re: [Tiki-devel] A default for the list of plugins, whose bodies should be indexed

Hi all,

Based on the elements I have collected, I will go through the code in order
to apply the suggested changes.

I will inform you about the progress.

Thank you !

On Sat, 8 Apr 2023 at 16:02, Volker Wysk <post-hhF2Jplw28UoZk/[email protected]> wrote:

> Am Montag, dem 03.04.2023 um 18:16 -0400 schrieb Benoit Grégoire:
> > > Here is my thought:
> > > - Add an option to each plugin (searchable="y|n"). Give the value
> > > searchable="y" to all the plugins that we want to index by default.
> >
> > Please don't call it searchable, that was the name of the future
> > "searchable"
> > parameter in plugin syntax params, which is NOT the same thing.
>
> I don't find it confusing. Anyway, what about "searchable_by_default"?
>
> > What you seem to be talking about is a defaultindexable key in the plugin
> > info
> > function, with 2 values (I suggest true and false, this is code, not
> > prefs).
> >
> > If the key is not present you'd treat it as false (to avoid having to
> > update
> > every single plugin).  It would also replace the need for the
> > unified_exclude_all_plugins='y'.
> >
> > > - Add another preference that we could call "Included plugins"
> different
> > > from "Except included plugins" (unified_included_plugins). This new
> > > preference will allow to include plugins with searchable="n" value that
> > > we
> > > want to make indexable without depending on "Exclude all plugins"
> > > preference.
> > > - Disable the preference "Exclude all plugins" by default, today this
> > > preference is enabled by default.
> >
> > Reading the code, the current behaviour is already confusing even for
> > developers.
> >
> > We have
> > unified_exclude_all_plugins , with default 'y'.  It doesn't do what it's
> > name
> > says.  It's essentially a unified_exclude_all_plugins_by_default.  I
> > propose we
> > remove it (because it has a value on currently running servers), unless
> > Victor
> > objects.
> >
> > unified_included_plugins , which currently does nothing, unless
> > unified_exclude_all_plugins is true.  On people's server it likely has
> the
> > list
> > of plugins they want indexed, so we can't really change it.  But it
> should
> > really be renamed to unified_additional_default_indexable_plugins. It's
> > only
> > used one place in the code in WikiText.php, so we can use
> > additional_default_plugins as the value name in the code)
> >
> > unified_excluded_plugins, This option does what it says, it
> > unconditionally
> > excludes those plugins from search.  We need this, to disable buggy
> > plugins
> > whose value crashes the index.
> >
> > Now, unless we go overboard with defaults, I don't think we need a
> > "unified_additional_default_not_indexable_plugins" to override the
> > default.
>
> This sure is confusing. But we don't need all this, when we introduce the
> "searchable" (or "searchable_by_default") setting for the plugin info
> functions. We only need two settings which override the defaults. Perhaps
> call them "include_plugins" and "exclude_plugins". Or "include_in_search"
> and "exclude_from_search". Or whatever.
>
> Volker
> _______________________________________________
> TikiWiki-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>

_______________________________________________
TikiWiki-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel