Re: [Tiki-devel] Asking for feedback: Tiki code organisation reorg, take ... 3?

On lundi 24 avril 2023 13 h 23 min 46 s EDT Jonny Bradley via TikiWiki-devel wrote:
> Hi Benoit
> 
> Thanks, that looks really good - there are a few comments i could make so
> will try and add them to the file, or as comments on gitlab... somehow,
> hmm, maybe i'll just do them here (sorry ;)
> 
> Re img/trackers and tracker_field_image this should be removed and i've
> added it to
> https://dev.tiki.org/Endangered-features#Candidates_for_removals_for_Tiki_2
> 6 Would be nice and a good time to remove img/wikiup and whelp maybe?
> 
> Wasn't the dir vendor_custom replaced by just `vendor` ages ago? I can't
> find any reference to that as a string in tiki currently, i don't really
> understand what it's for (on https://packages.tiki.org/ it says you can
> install tiki-pig-pdfjs there but how does tiki know to use it?) Possibly my
> misunderstanding...

It's not:  https://gitlab.com/tikiwiki/tiki/-/tree/master/vendor_custom[1]

Any I can find it by string in 13 different non-documentation files ;)

> Dir /files should be removed so we can use that as the short url to
> tiki-list_file_gallery.php :p

Ok, moved the last remnants (lib/pref/fgal.php and lib/comments/commentslib.php) in a 
commit I'll finish today.
 
> Dir /profiles as you guessed it write only so should be in /private i think,
> possibly /private/storage/profiles but /private/export/profiles would be
> more obvious (and maybe db backups etc could default there too).

Part of the point of the storage directories is that everything in them should be backed-
up.  Part of the point of temp is that it should be cleaned-up, either by code or manually.

If it's truly write only, I think it should go in temp/export/profiles

As for db and other backups I don't think we have a default.  "php console.php 
database:backup"  doesn't.  If it did, I think it should go to temp/backup/db
 
> Question: Do the compiled output of vue.js projects etc go in
> /public/generated then? Sorry not clear on that bit...

Yes

> I'm also not totally clear on how "multi-tiki" directories should be
> structured, i'm quite a fan of it (have made a few fixes and improvements
> on it over the years) and will muse how this should work in the new regime
> and get back to you (in the md doc).
> 
> Many thanks for resurrecting this important and difficult project, one last
> question:
> 
>     When? For tiki 28 maybe?

There is no deadline for completing it, it depends on resources and opportunity.  But 
vue.js generation and the dependence on node for git installs needs to get in for Tiki 26.
-- 
Benoit Grégoire

--------
[1] https://gitlab.com/tikiwiki/tiki/-/tree/master/vendor_custom

_______________________________________________
TikiWiki-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel