Re: [Tiki-devel] A default for the list of plugins, whose bodies should be indexed

Volker Wysk <post-hhF2Jplw28UoZk/[email protected]> Fri, 05 May 2023 16:59:52 +0200
Newsgroups	gmane.comp.cms.tiki.devel
Message-ID	<[email protected]>
Am Mittwoch, dem 03.05.2023 um 11:20 -0400 schrieb Benoit Grégoire:
> On mardi 2 mai 2023 01 h 47 min 24 s EDT Volker Wysk wrote:
> > Hi Adrien and all!
> > 
> > Am Sonntag, dem 30.04.2023 um 19:40 +0300 schrieb Adrien Maloba:
> > > Hi all !
> > > 
> > > Thanks to everyone for your contributions. I have launched a request
> > > that
> > > is already merged in Tiki Trunk (26.x). Here is the link
> > > https://gitlab.com/tikiwiki/tiki/-/merge_requests/2532
> > 
> > I don't mean to nag, but I wouldn't call it like this. It's symmetric.
> > We
> > have plugins which are to be searchable by default and can be made non-
> > searchable by a global setting. And we have plugins which are to be non-
> > searchable by default and can be made searchable by another global
> > setting.
> > 
> > This should be reflected in the names of the two global settings. When
> > you
> > call one of them "Excluded plugins", you should call the other "Included
> > plugins", not "Additional plugins searchable by default".
> 
> No, it is not symetric, that's why it's described differently.
> 
> "Excluded plugins" will exclude plugins regardless of ANY other setting. 
> It's there mostly in case the plugin code is buggy.  There is no "Exclude
> all plugins" settings anymore.
> 
> Plugins in the "Additional plugins searchable by default" list on the
> other hand will obey other settings, it's just a default.  Plugins in the
> list will still obey the searchable plugin parameter, as well as "Excluded
> plugins".
> 
> We COULD have added another setting "Additional plugins excluded by
> default" which would be symetric.  Unless we go overboard with setting
> defaults on, there is very little use case for it once searchable is
> implemented, and it complexifies the admin even more.
> 
> I tried and obviously failed repeatedly to explain it clearly enough in
> prose.   I think it's clearer in the code:
> https://gitlab.com/tikiwiki/tiki/-/blob/master/lib/core/WikiParser/Parsable.php#L168

I don't get it.

I'm NOT saying that it is symmetric the way it is now. I'm saying that it
could (and should) be made symmetric easily.

I would do it like this: Each plugin gets an "searchable_by_default"
parameter, which is set in the plugin's info function. This should probably
default to "no". Two settings are added, "include_in_search" and
"exclude_from_search". They contain a list of plugin names and override the
"searchable_by_default" parameters. An optional "searchable" parameter to
all plugins, as specified in the wiki pages, is added. It overrides both
"searchable_by_default" and "include_in_search"/"exclude_from_search".

That's all that is needed. I find it easy to comprehend.

Regards,
Volker

_______________________________________________
TikiWiki-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
signature.asc (application/pgp-signature, 833 B)