Re: [Tiki-devel] Change of behavior in Tiki26 for tracker wikiplugin notifications

Hi Bernard, Jonny,

I have changed the email template links a bit in Tiki 26 as old 
machine_url/base_url way of building links was a bit messy. The current 
templates (e.g. tracker_changed_notification.tpl) uses this syntax:

{mailurl}{$mail_itemId|sefurl:'trackeritem'}{/mailurl}

We basically put all URLs of email templates inside mailurl smarty 
block, so it can take care of prepending the possibly relative links 
with proper absolute url. It also takes care of not breaking absolute urls.

What Bernard sees is most probably a missing call to sefurl helpers to 
make the proper URL in a custom email template.

Regards,
Victor

On 8/5/23 2:15 PM, Jonny Bradley via TikiWiki-devel wrote:
> Hi Bernard
>
> That looks like it comes from this line of code
>
>      lib/trackers/trackerlib.php:5741
>
> so it looks like you're using the "simple mail" format of notification? (which i thought was deprecated many years ago).
>
> However, it looks like the link is just `" $machine/tiki-view_tracker_item.php?itemId=$itemId\n\n"` but that isn't even sefurl, so have you customised this at some point maybe?
>
> jonny
>
>
>   
>> On 5 Aug 2023, at 07:01, Bernard Sfez via TikiWiki-devel <[email protected]> wrote:
>>
>> Hello,
>>
>> On my own website I have a contact form based on tracker and the TRACKER wikiplugin.
>> In the tracker wikiplugin I have set the “email” option with my email.
>>
>> For years I received this kind of notification from Tiki. (Last received on the 1/08/2023)
>>
>> =====
>>
>> Subject: "Contact form" item "Rodger" was modified at www.bsfez.com by “Anonymous"
>> Body: “
>> View the tracker item at:    https://www.bsfez.com/itemxxx
>> Author:
>> Date:  01/08/2023 19:24
>> "
>> And at the bottom my Tiki general preferences footer.
>>
>> The link goes to the tracker view item interface.
>>
>> =====
>>
>> Since yesterday (4/08/2023) on this site, a Tiki26 continuously updated the link attached has been modified and they look like this.
>>
>> https://www.bsfez.com/tiki-ajax_services.php?controller=tracker&action=update_item&trackerId=14&itemId=600
>>
>> And this link goes to the update/edit item tracker interface which in my opinion is not right.
>>
>>
>> Was this change made on purpose and part of a plan or should it be reported as a bug (regression?)
>>
>> Bernard
>>
>> _______________________________________________
>> TikiWiki-devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>
>
> _______________________________________________
> TikiWiki-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel


_______________________________________________
TikiWiki-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel