Re: [Tiki-devel] PHP module problem with 27.1 - RE: Tiki-27.1 Release

Hi Jonny et al

Belated thanks for this feedback and just to let you know I have now set up a new 'vanilla' Tiki 27.1 instance i.e. just as it comes 'out of the box' with no history and no additional features - all on a local server (obviously a Raspberry Pi as its me!) so that I can control all aspects of the PHP config and to further investigate the impact of hosting companies 'imposing' disabled PHP functions on users - which is probably quite a widespread practice.

Your insight and more careful examination of the code below re the 'posix' functions looks as if it is spot on, so on my local 'vanilla' system I made the following simple one-line changes:
/installer/installlib.php @ line 171 changes to:
    if (function_exists('posix_getuid') && function_exists('posix_getpwuid')) {

and 

/lib/setup/ tikisetup.class.php @ line 49 changes to:
    if (function_exists('posix_getuid') && function_exists('posix_getpwuid')) {

These changes all look good as I did a full "tiki-install.php cycle" and some basic usage tests without any issues.

Obviously, someone needs to do the 'proper MR' stuff as (despite your historic help!) this has always been a bit too much for my 'fading brain' :-)

More disabled PHP investigation stuff to follow!

Cheers

Geoff



-----Original Message-----
From: Jonny Bradley via TikiWiki-devel <[email protected]> 
Sent: 03 December 2024 10:44
To: Tiki Wiki CMS Groupware <[email protected]>
Cc: Jonny Bradley <[email protected]>
Subject: Re: [Tiki-devel] PHP module problem with 27.1 - RE: Tiki-27.1 Release

Hi Geoff

Looks like that bit of code tests for `function_exists('posix_getuid')` but then uses both `posix_getuid` and `posix_getpwuid`, which it didn't check for (and what your error shows).

So maybe that's it?

Those lines have been in installlib.php since 2021 (so it's the same in 24.x), same for the code in tikisetup.class.php - so i think the fix would be to check for both functions or check for the extension... although the manual says:

> This extension is enabled by default. It may be disabled by using the 
> following option at compile time: --disable-posix


So sounds like your hosting company has done something a bit unusual in blocking just `posix_getpwuid`, but we can improve the test by checking for both functions which should fix this (any volunteers? ;)

jb




 
> On 3 Dec 2024, at 09:43, Geoff - Enmore Services <[email protected]> wrote:
> 
> Yet more on this  ………………
>  So, I tracked another ‘check’ in /lib/setup/tikisetup.class.php at lines49-55   – so I commented these out as well and now – more checking to do!! – but it seems to be running
>  Googling around it looks like lots of hosters routinely disable this posix function so something obviously needs to be done about this !
>  Cheers
>  Geoff
>    
>> From: Geoff - Enmore Services <[email protected]>
>> Sent: 03 December 2024 09:11
>> To: 'Tiki developers' <[email protected]>
>> Subject: Re: [Tiki-devel] PHP module problem with 27.1 - RE: 
>> Tiki-27.1 Release  More on this ……..
>>  Looking at /installer/installlib.php the ‘offending code is at lines 171-177 and is a check on whether 'posix_getuid' exists – so for some reason my hoster’s system is obviously giving a false positive to this test (or the if check is not correct in some way?)– so as a hack I simply commented out these lines and re-ran tiki-install.php.
>>  This then ran OK, completing the db update (100 queries completed) but at the last ‘continue’ step it just produced a blank white screen – so something is still not right.
>>  Suggestions please!
>>  Geoff
>>  
>>> From: Geoff - Enmore Services <[email protected]>
>>> Sent: 02 December 2024 21:55
>>> To: 'Tiki developers' <[email protected]>
>>> Subject: [Tiki-devel] PHP module problem with 27.1 - RE: Tiki-27.1 
>>> Release  Hi all – I’ve just tried to do an upgrade from 24.6 to 27.1 and I’ve hit what is a significant problem (at least for me!).
>>>  When running the installer (using php8.3) I get a fatal error as 
>>> shown below (blah blah used to change the detailed paths)  Fatal 
>>> error: Uncaught Error: Call to undefined function posix_getpwuid() 
>>> in /blah blah/installer/installlib.php:172 Stack trace: #0 / blah 
>>> blah /installer/tiki-installer.php(244): get_webserver_uid() #1 / 
>>> blah blah /tiki-install.php(132): include_once(' blah blah /...') #2 {main} thrown in / blah blah /installer/installlib.php on line 172  These days I run my public stuff on a cheap and cheerful UK based hoster, so I reached out to them to see how I could add the needed posix module to their php8.3 but sadly they have come back to me saying:
>>> “All the PHP modules we allow are enabled by default so there is no option to select modules within cPanel. The module "posix_getpwuid" is actually in our disabled list for security reasons ………………..”
>>>  This is obviously a big problem for me as I really don’t want to figure out another hoster BUT I’m wondering:
>>> - why this posix module has been introduced?
>>> - how extensive is its use in 27.1?
>>> - is it really a security concern?
>>> - is there an obvious alternative/work around  Any/all thoughts 
>>> really appreciated  Thanks  Geoff
>>>   
>>>> From: Rodriguez Nyiringabo <[email protected]>
>>>> Sent: 23 November 2024 16:51
>>>> To: Tiki developers <[email protected]>
>>>> Subject: Re: [Tiki-devel] Tiki-27.1 Release  Dear Devs,  We've 
>>>> released Tiki-27.1.
>>>> Tarballs are here: 
>>>> https://sourceforge.net/projects/tikiwiki/files/Tiki_27.x_Miaplacid
>>>> us/27.1/
>>>>  Best regards,
>>>> Rodriguez Nyiringabo
>>>>  Le sam. 23 nov. 2024 à 16:47, Rodriguez Nyiringabo <[email protected]> a écrit :
>>>>>> Dear Devs,
>>>>>>  We're releasing Tiki 27.1 right now. 
>>>>>>  Please don't commit/merge to branch 27.x until we are done.
>>>>>>  Thanks!
>>>>>> Rodriguez Nyiringabo
>>>>> 
>>>>>  
>>>> Virus-free.www.avg.com
>>>>  _______________________________________________
>>>> TikiWiki-devel mailing list
>>>> [email protected]
>>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>>> 
>>> 


_______________________________________________
TikiWiki-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel


--
This email has been checked for viruses by AVG antivirus software.
www.avg.com


-- 
This email has been checked for viruses by AVG antivirus software.
www.avg.com


_______________________________________________
TikiWiki-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel