Re: [Tiki-devel] Creating custom theme with options (Fix inside)

Benoit GrĂ©goire <[email protected]> Fri, 06 Jun 2025 13:40:09 -0400
Newsgroups gmane.comp.cms.tiki.devel
Message-ID <2698632.Lt9SDvczpP@benoitg-xps-13>
This is a multi-part message in MIME format.

--===============1215302237594618381==
Content-Type: multipart/alternative; boundary="nextPart4472694.ejJDZkT8p0"
Content-Transfer-Encoding: 7Bit

This is a multi-part message in MIME format.

--nextPart4472694.ejJDZkT8p0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"

On vendredi 6 juin 2025 13 h 02 min 09 s heure avanc=C3=A9e de l=E2=80=99Es=
t Karsten Wemheuer=20
wrote:
> Hi,
>=20
> thanks for the pointer. I finally found the error. That weird path with
> the missing / is produced in tiki-tc.php, line 57.
>=20
> original:
> $headerlib->add_cssfile("{$tc_theme_path}css/{$tc_theme_option}.css");
>=20
> fixed:
> $headerlib->add_cssfile("{$tc_theme_path}/css/{$tc_theme_option}.css");
>=20
> I have included a patch. The solution works for me. But I don't know if
> it has unintended side effects.
>=20
> I compared the file from tiki 27.2 with tiki 28.3. As they are
> identical, I assume the patch works for Tiki 27 and Tiki 28.
>=20
> Best regards
>=20
> Karsten

Thanks!

https://gitlab.com/tikiwiki/tiki/-/merge_requests/7708[1]
=2D-=20
Benoit Gr=C3=A9goire

=2D-------
[1] https://gitlab.com/tikiwiki/tiki/-/merge_requests/7708

--nextPart4472694.ejJDZkT8p0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset="utf-8"

<html>
<head>
<meta http-equiv=3D"content-type" content=3D"text/html; charset=3DUTF-8">
</head>
<body><p style=3D"margin-top:0;margin-bottom:0;margin-left:0;margin-right:0=
;">On vendredi 6 juin 2025 13 h 02 min 09 s heure avanc=C3=A9e de l=E2=80=
=99Est Karsten Wemheuer wrote:</p>
<p style=3D"margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">&gt=
; Hi,</p>
<p style=3D"margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">&gt=
; </p>
<p style=3D"margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">&gt=
; thanks for the pointer. I finally found the error. That weird path with</=
p>
<p style=3D"margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">&gt=
; the missing / is produced in tiki-tc.php, line 57.</p>
<p style=3D"margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">&gt=
; </p>
<p style=3D"margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">&gt=
; original:</p>
<p style=3D"margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">&gt=
; $headerlib-&gt;add_cssfile(&quot;{$tc_theme_path}css/{$tc_theme_option}.c=
ss&quot;);</p>
<p style=3D"margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">&gt=
; </p>
<p style=3D"margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">&gt=
; fixed:</p>
<p style=3D"margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">&gt=
; $headerlib-&gt;add_cssfile(&quot;{$tc_theme_path}/css/{$tc_theme_option}.=
css&quot;);</p>
<p style=3D"margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">&gt=
; </p>
<p style=3D"margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">&gt=
; I have included a patch. The solution works for me. But I don't know if</=
p>
<p style=3D"margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">&gt=
; it has unintended side effects.</p>
<p style=3D"margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">&gt=
; </p>
<p style=3D"margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">&gt=
; I compared the file from tiki 27.2 with tiki 28.3. As they are</p>
<p style=3D"margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">&gt=
; identical, I assume the patch works for Tiki 27 and Tiki 28.</p>
<p style=3D"margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">&gt=
; </p>
<p style=3D"margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">&gt=
; Best regards</p>
<p style=3D"margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">&gt=
; </p>
<p style=3D"margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">&gt=
; Karsten</p>
<br /><p style=3D"margin-top:0;margin-bottom:0;margin-left:0;margin-right:0=
;">Thanks!</p>
<br /><p style=3D"margin-top:0;margin-bottom:0;margin-left:0;margin-right:0=
;"><a href=3D"https://gitlab.com/tikiwiki/tiki/-/merge_requests/7708">https=
://gitlab.com/tikiwiki/tiki/-/merge_requests/7708</a></p>
<p style=3D"margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">-- =
</p>
<p style=3D"margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">Ben=
oit Gr=C3=A9goire</p>
</body>
</html>
--nextPart4472694.ejJDZkT8p0--





--===============1215302237594618381==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline


--===============1215302237594618381==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
TikiWiki-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

--===============1215302237594618381==--