Re: 1 cset was pushed to modules/articles: xar_articles_pictures.js: fixes js func...

"Jason Judge" <[email protected]>
Newsgroups gmane.comp.cms.xaraya.bk-notices
Organization Xaraya
Message-ID <[email protected]>
"Carl P. Corliss" <rabbitt-111RdWWlOxkOkXtL6OYfHgC/[email protected]> wrote in message
news:[email protected]...
> Changes were applied by rabbitt to modules/articles level 20.
>     The following cset was applied:
>
>     ChangeSet
>       1.535 05/04/02 10:29:43 [email protected] +2 -0
>       xar_articles_pictures.js:
>         fixes js function names so they don't clobber js functions
included from elsewhere.

Thanks. The file itself could probably be renamed back to gallery.js, or
pictures.js, which makes more sense. We don't prefix any of the other
stylesheets or API files with the the module name or 'xar_'. I don't think
there is any benefit in doing it for JS files.

This script also happens to over-write the onload trigger for the page. Not
sure what we can do about that, but it will potentially break other scripts
running on the same page that also rely on onload triggers. Just something
to be aware of, because we don't have any guidelines on how to handle onload
triggers, AFAIK...?

-- JJ
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.