Re: 1 cset was pushed to modules/xarpages: Minor bug fix. Now using the themes osdi...
Brian McGilligan <brian-4Y3+cfMDcQXD0D/[email protected]>
| Newsgroups | gmane.comp.cms.xaraya.bk-notices |
|---|---|
| Organization | Xaraya |
| Message-ID | <[email protected]> |
I needed to change it to use the os dir because with themes like the print theme the theme name is different from the osdirectory. So when you set the Theme to "Print" xarTplSetThemeName() fails cause there is not "Print" directory in the themes directory. So since xarTplSetThemeName() checks to see if a theme exists in the filesystem shouldn't it use the osdirectory? Brian Jason Judge wrote: > Brian, > > Could you explain the reasoning behind this, since it does change the > functionality. The name of the theme is stored, because when setting a > theme, it is the name that is used to set it, not the osdirectory. Your > change now means the os directory is stored rathe than the theme name. > > -- JJ > > > "Brian McGilligan" <brian-111RdWWlOxkOkXtL6OYfHgC/[email protected]> wrote in message > news:[email protected]... > >>Changes were applied by bmcgilligan to modules/xarpages level 20. >> The following cset was applied: >> >> ChangeSet >> 1.335 05/04/17 17:36:11 bmcgilligan-Kfeq/[email protected] +1 -0 >> Minor bug fix. Now using the themes osdirectory instead of the name >> when setting themes for pages. >> >> xartemplates/admin-modifypage.xd >> 1.13 05/04/17 17:36:08 bmcgilligan-Kfeq/[email protected] +2 -2 >> Minor bug fix. Now using the themes osdirectory instead of the > > name > >> when setting themes for pages. >> >>Links for the differences: >>http://xaraya.com:15000/modules/xarpages/[email protected] > > >