Re: 1 cset was pushed to modules/xarpages: Minor bug fix. Now using the themes osdi...

Jason Judge wrote:

> Nope. If xarTplSetThemeName() is not setting the theme by its *name* then it
> is that which needs fixing. Bug 3876 is tracking this problem. We should fix
> it from that end.
> 
> -- JJ


So

function xarTplSetThemeName($themeName)
{
     assert('$themeName != "" && $themeName{0} != "/"');
     if (!file_exists($GLOBALS['xarTpl_themesBaseDir'].'/'.$themeName)) {
         return false;
     }

     xarTpl__SetThemeNameAndDir($themeName);
     return true;
}


should be

function xarTplSetThemeName($themeName)
{
     $themeInfo = xarModInfo(xarModGetIDFromName($themeName, 'theme'), 
'theme');
     $themeDir = $themeInfo['osdirectory'];
     assert('$themeDir != "" && $themeDir{0} != "/"');
     if (!file_exists($GLOBALS['xarTpl_themesBaseDir'].'/'.$themeDir)) {
         return false;
     }

     xarTpl__SetThemeNameAndDir($themeName);
     return true;
}

or something like it, right?

I'll go ahead and undo my commit to xarPages. Sorry about messing with 
xarPages.

Brian