Re: 4 csets were pushed to core/stable: Merge [email protected]:/var/bk/xaraya/...

"mikespub" <[email protected]> wrote in message 
news:[email protected]...
> Jo Dalle Nogare wrote:
>>
> Same issue with templates as for the other property classes.
>
> You need to replace
> return xarTplModule('dynamicdata', 'admin', '...', $data , $template);
>
> by
>
> return xarTplProperty('dynamicdata', $template, '...', $data);
>
> and *not* silently ignore $template coming from elsewhere, or
> you'll break stuff...

Mike, i'm not ignoring $template - see my post on committers about which 
properties need fixing for the sub templates.

These are done as per instruction for the new xarTplProperty changes, to 
initialize $template to empty. However, afaics, we need to put in place the 
overrides for 'sub' templates. Just putting in $template doesn't necessarily 
work now that the properties have been moved out to respective modules. So, 
your feedback as per committer list posts are appreciated.

Jo


> Thanks,
>
> Mike.