Re: 2 csets were pushed to core/stable: Merge [email protected]:/var/bk/xaraya...
[email protected] (mikespub)
| Newsgroups | gmane.comp.cms.xaraya.bk-notices |
|---|---|
| Organization | not much |
| Message-ID | <[email protected]> |
In article <[email protected]>, "jojodee" <[email protected]> wrote: >... >That sounds like a very useful thing to do :) >Any potential impact elsewhere - negative or otherwise? > >Jo > Database-wise, you get a bigger table and slower access - but since we're talking about a few hundred records max. here (= the property definitions for whatever dynamic objects you have on your site), the difference should be invisible. Processing-wise, the systematic use of unserialize() would slow things down a bit - but on the other hand it would allow you to simplify the parsing of the validation rule in the property types, so property types with complex validations would probably benefit anyway. And the others can just keep using their one-liners as before :-) Upgrade-wise, we'd be changing a column type of a core table, so someone more familiar with the latest AlterTable/DDL issues should probably take a look at this to make sure both MySQL and Postgres accept the change. And yes, it does require an upgrade for users - unless you want to simply ignore the change for older sites (with the risk of hitting the 254-char size limit somewhere down the road) GUI-wise, nothing needs to be changed off-hand, but we may want to remove the validation input field from the DD modifyprop page later on and leave just the showpropval() link to update the validation. Functionality-wise, property types like Select, UserList and *Uploads can certainly benefit from greater flexibility in configuration and validation, so those would probably switch over to a serialized validation field soon to allow more options. They could do that now too, but then you'd hit that 254-char size limit pretty quickly... That's about it I guess - so the only thing that worries me a bit is the AlterTable stuff :-) Mike.