48 csets were pushed to core/stable: Merge hsdev.com:/var/bk/xar/core/xartest...

Changes were applied by marcel to core/stable level 10.
    WARNING: These changes bypassed the Quality Assurance Tests!
    The following csets were applied:
    
    ChangeSet
      1.2030 05/02/21 15:18:49 [email protected] +1 -0
      Merging stable into sqlite scenario (which includes the ap2block scenario now)
    
      html/includes/xarTableDDL.php
        1.68 05/02/21 15:18:47 [email protected] +1 -1
        Merging stable into sqlite scenario (which includes the ap2block scenario now)
    
    ChangeSet
      1.2029 05/02/21 14:11:26 [email protected] +2 -0
      - replacing a & with @ to suppress the error which will be generated if the changeTable method is used to create tables 
      (yes, that sound unintuitive, but apparently that is the case). This fixes the blocker for installing xarpages with sqlite
      and should not hurt other databases (logic didnt change)
      I'll let jason reconfirm this for other databases.
    
      html/xaradodb/drivers/adodb-sqlite.inc.php
        1.9 05/02/21 14:11:24 [email protected] +3 -1
        Inserting a comment related to the change in the datadict file.
    
      html/xaradodb/adodb-datadict.inc.php
        1.9 05/02/21 14:11:23 [email protected] +6 -1
        - replacing a & with @ to suppress the error which will be generated if the changeTable method is used to create tables 
        (yes, that sound unintuitive, but apparently that is the case). This fixes the blocker for installing xarpages with sqlite
        and should not hurt other databases (logic didnt change)
        I'll let jason reconfirm this for other databases.
    
    ChangeSet
      1.2025 05/02/20 09:01:36 [email protected] +1 -0
      - put the most global setting on top
      - add a hint that for SQlite host is a directory
    
      html/modules/installer/xartemplates/admin-phase4.xd
        1.39 05/02/20 09:01:34 [email protected] +27 -21
        - put the most global setting on top
        - add a hint that for SQlite host is a directory
    
    ChangeSet
      1.2024 05/02/19 13:49:37 [email protected] +2 -0
      Make errors more apparent for sqlite (and show the right error at that)
    
      html/xaradodb/drivers/adodb-sqlite.inc.php
        1.8 05/02/19 13:49:35 [email protected] +9 -2
        make errors more apparent
    
      html/xaradodb/adodb.inc.php
        1.46 05/02/19 13:49:35 [email protected] +1 -1
        - make errors more apparent 
    
    ChangeSet
      1.2023 05/02/19 10:07:51 [email protected] +1 -0
      Strip out backquotes from sql statements. Obviously this should be a bit more intelligent, if bindvars are not use for all queries, a 
      backquote in content could produce interesting results :-)
    
      html/xaradodb/drivers/adodb-sqlite.inc.php
        1.7 05/02/19 10:07:50 [email protected] +3 -0
        Strip out backquotes from sql statements. Obviously this should be a bit more intelligent, if bindvars are not use for all queries, a 
        backquote in content could produce interesting results :-)
    
    ChangeSet
      1.2022 05/02/18 16:56:11 [email protected] +2 -0
      Reintroduce Mike's changes for checking whether a database type is available. In a merge i choose the local changes for the 
      installer. The reimplementation is slightly different.
    
      html/modules/installer/xartemplates/admin-phase4.xd
        1.38 05/02/18 16:56:09 [email protected] +8 -4
        adjustment for the db available changes
    
      html/modules/installer/xaradmin.php
        1.156 05/02/18 16:56:09 [email protected] +4 -4
        pass info to the template whether a certain database is available or not
    
    ChangeSet
      1.2021 05/02/18 16:28:47 marcel-097TUEbwl1/[email protected] +1 -0
      Merge hsdev.com:/var/bk/xar/core/xartest
      into hsdev.com:/var/bk/xar/core/sqlite
    
      html/modules/installer/xaradmin.php
        1.155 05/02/18 16:28:47 marcel-097TUEbwl1/[email protected] +0 -0
        Auto merged
    
    ChangeSet
      1.2020 05/02/18 16:01:06 marcel-097TUEbwl1/[email protected] +2 -0
      Merge hsdev.com:/var/bk/xar/core/xartest
      into hsdev.com:/var/bk/xar/core/sqlite
    
      html/modules/installer/xartemplates/admin-phase4.xd
        1.37 05/02/18 16:01:05 marcel-097TUEbwl1/[email protected] +0 -0
        Auto merged
    
      html/modules/installer/xaradmin.php
        1.154 05/02/18 16:01:05 marcel-097TUEbwl1/[email protected] +0 -0
        Auto merged
    
    ChangeSet
      1.2019 05/02/18 14:20:12 marcel-097TUEbwl1/[email protected] +2 -0
      Merge hsdev.com:/var/bk/xar/core/xartest
      into hsdev.com:/var/bk/xar/core/sqlite
    
      html/modules/base/xarinit.php
        1.139 05/02/18 14:20:12 marcel-097TUEbwl1/[email protected] +0 -0
        Auto merged
    
      html/includes/xarTableDDL.php
        1.67 05/02/18 14:20:12 marcel-097TUEbwl1/[email protected] +0 -0
        Auto merged
    
    ChangeSet
      1.2018 05/02/03 08:13:59 [email protected] +5 -0
      Merging stable into the sqlite scenario
    
      html/modules/installer/xartemplates/admin-phase4.xd
        1.36 05/02/03 08:13:58 [email protected] +1 -10
        related to the extension availability testing, which need to be remerged
    
      html/modules/installer/xaradmin.php
        1.153 05/02/03 08:13:58 [email protected] +21 -51
        - For now, use the install logic of sqlite installer, the installer has been cleaned UP
        - To remerge: extension availability testing for the database drivers
    
      html/modules/base/xarinit.php
        1.138 05/02/03 08:13:58 [email protected] +2 -3
        - version number of themes mod changed, reflect this in base init
    
      html/modules/dynamicdata/xarinit.php
        1.53 05/02/03 08:04:13 marcel-097TUEbwl1/[email protected] +0 -0
        Auto merged
    
      html/includes/xarTableDDL.php
        1.66 05/02/03 08:04:13 marcel-097TUEbwl1/[email protected] +0 -0
        Auto merged
    
    ChangeSet
      1.1979.1.17 04/12/23 09:37:53 marcel-097TUEbwl1/[email protected] +1 -0
      Merge hsdev.com:/var/bk/xar/core/xartest
      into hsdev.com:/var/bk/xar/core/sqlite
    
      html/modules/base/xarinit.php
        1.137 04/12/23 09:37:52 marcel-097TUEbwl1/[email protected] +0 -0
        Auto merged
    
    ChangeSet
      1.1979.1.13 04/12/12 09:58:14 [email protected] +1 -0
      Not merging the dbconnecting logic, as that changed anyway in sqlite scenario. Need to check this again for postgres before merging, 
      but i think the same bug was solved in another way
    
      html/modules/installer/xaradmin.php
        1.152 04/12/12 09:58:12 [email protected] +1 -21
        Not merging the dbconnecting logic, as that changed anyway in sqlite scenario. Need to check this again for postgres before merging, 
        but i think the same bug was solved in another way
    
    ChangeSet
      1.1979.1.10 04/12/06 12:18:01 marcel-097TUEbwl1/[email protected] +1 -0
      Merge hsdev.com:/var/bk/xar/core/xartest
      into hsdev.com:/var/bk/xar/core/sqlite
    
      html/modules/adminpanels/xarinit.php
        1.52 04/12/06 12:18:01 marcel-097TUEbwl1/[email protected] +0 -0
        Auto merged
    
    ChangeSet
      1.1957.34.1 04/11/29 09:37:07 marcel-097TUEbwl1/[email protected] +1 -0
      Merge hsdev.com:/var/bk/xar/core/xartest
      into hsdev.com:/var/bk/xar/core/sqlite
    
      html/modules/privileges/xarinit.php
        1.48 04/11/29 09:37:06 marcel-097TUEbwl1/[email protected] +0 -0
        Auto merged
    
    ChangeSet
      1.1957.1.30 04/11/09 15:43:05 [email protected] +1 -0
      tabs
    
      html/xaradodb/datadict/datadict-sqlite.inc.php
        1.3 04/11/09 15:43:03 [email protected] +17 -17
        tabs
    
    ChangeSet
      1.1957.1.29 04/11/09 15:41:19 [email protected] +1 -0
      brace
    
      html/xaradodb/datadict/datadict-sqlite.inc.php
        1.2 04/11/09 15:41:17 [email protected] +3 -6
        brace
    
    ChangeSet
      1.1957.1.28 04/11/09 15:38:53 [email protected] +1 -0
      Initial subclass for datadict for sqlite backend, need more modules which use this
    
      html/xaradodb/datadict/datadict-sqlite.inc.php
        1.1 04/11/09 15:38:51 [email protected] +65 -0
    
      html/xaradodb/datadict/datadict-sqlite.inc.php
        1.0 04/11/09 15:38:51 [email protected] +0 -0
        BitKeeper file /var/bk/xar/core/sqlite/html/xaradodb/datadict/datadict-sqlite.inc.php
    
    ChangeSet
      1.1957.1.26 04/11/07 18:18:24 [email protected] +1 -0
      Implementing the xarDB__sqliteAlterTable() function for SQLite
      This concludes the needed functionality.
    
      html/includes/xarTableDDL.php
        1.65 04/11/07 18:18:18 [email protected] +39 -1
        Implementing the xarDB__sqliteAlterTable() function for SQLite
        This concludes the needed functionality.
    
    ChangeSet
      1.1957.1.25 04/11/07 18:16:39 [email protected] +1 -0
      - Adding code for ALTER TABLE <sometable> RENAME TO <newtablename>
      - refactoring the var naming for it
    
      html/xaradodb/drivers/adodb-sqlite.inc.php
        1.6 04/11/07 18:16:26 [email protected] +30 -21
        - Adding code for ALTER TABLE <sometable> RENAME TO <newtablename>
        - refactoring the var naming for it
    
    ChangeSet
      1.1957.1.24 04/11/07 16:23:55 [email protected] +1 -0
      ALTER TABLE emulation for SQLite.
      - Initial implementation
      - Does not use an atomic transaction yet, and as such i didnt use a temp table yet, so no data will be lost if something goes wrong
    
      html/xaradodb/drivers/adodb-sqlite.inc.php
        1.5 04/11/07 16:23:41 [email protected] +153 -5
        ALTER TABLE emulation for SQLite.
        - Initial implementation
        - Does not use an atomic transaction yet, and as such i didnt use a temp table yet, so no data will be lost if something goes wrong
    
    ChangeSet
      1.1957.1.23 04/11/07 12:09:39 [email protected] +1 -0
      Dont put the serialized value direct into the function.
      xarConfigSetVar serializes internally. 
    
      html/modules/base/xarinit.php
        1.136 04/11/07 12:09:30 [email protected] +7 -1
        Dont put the serialized value direct into the function.
    
    ChangeSet
      1.1957.1.22 04/11/06 15:27:35 [email protected] +1 -0
      Bring in the framework for an ALTER TABLE emulation for SQLite, all other functionality should NOT be affected by 
      this. Hence me pushing, so there can be some usage over time, before the _altertable() method is implemented.
      Hopefully we've caught possible errors by then.
    
      html/xaradodb/drivers/adodb-sqlite.inc.php
        1.4 04/11/06 15:27:31 [email protected] +29 -0
        Bring in the framework for an ALTER TABLE emulation for SQLite, all other functionality should NOT be affected by 
        this. Hence me pushing, so there can be some usage over time, before the _altertable() method is implemented.
        Hopefully we've caught possible errors by then.
    
    ChangeSet
      1.1957.1.21 04/11/06 14:52:58 [email protected] +1 -0
      cleaning up a little plus adding some phpdoc to clarify what it is all about.
    
      html/includes/xarTableDDL.php
        1.64 04/11/06 14:52:54 [email protected] +24 -60
        clean up a little
    
    ChangeSet
      1.1957.1.20 04/11/06 14:51:26 [email protected] +2 -0
      Also retrieve the dbtype and use it in the template
    
      html/modules/installer/xartemplates/admin-phase4.xd
        1.35 04/11/06 14:51:21 [email protected] +5 -3
        use the retrieved db type to signal which option is selected
    
      html/modules/installer/xaradmin.php
        1.151 04/11/06 14:51:21 [email protected] +1 -1
        also retrieve the db type
    
    ChangeSet
      1.1957.7.1 04/11/06 09:18:27 [email protected] +9 -0
      Minimal changes, to let installer use SQLite and end up with a working Xaraya
      Obviously lots of issues, the bigger ones are:
      - SQLite has no ALTER TABLE, so forget upgrading for the moment
      - SQLite autocreates databases, so when connecting and using SelectDB method, an empty database will *always* exist, 
      which might confuse the users when installing (overwrite my database? huh? etc. )
    
      html/xaradodb/drivers/adodb-sqlite.inc.php
        1.3 04/11/06 09:18:23 [email protected] +25 -2
        Xaraya modifications for the SQLite driver:
        - return null for the GenId method instead of emulating sequences
        - missing dataProvider property (bug in adodb?)
        - interpret host as directory and dbname as the filename, makes more sense than putting it all in hostname (upstream?)
        - Implement the SelectDB function (this is kinda moot, because SQLite autocreates databases when they dont exist)
    
      html/modules/privileges/xarinit.php
        1.47 04/11/06 09:18:23 [email protected] +20 -20
        - Use bindvars, required for SQLite
    
      html/modules/modules/xarinit.php
        1.46 04/11/06 09:18:23 [email protected] +24 -22
        - Use bindvars, required for SQLite
    
      html/modules/installer/xaradmin.php
        1.150 04/11/06 09:18:22 [email protected] +12 -4
        - Adding SQLite as install option
        - The connect method for SQLite needs the dbname, i think it could be used for the others too (i.e. specified, not used)
    
      html/modules/dynamicdata/xarinit.php
        1.52 04/11/06 09:18:22 [email protected] +6 -6
        Use bindvars where possible 
    
      html/modules/blocks/xaradminapi/update_instance_groups.php
        1.5 04/11/06 09:18:22 [email protected] +19 -12
        - Reformulate the update instances function, so it bails out earlier if something goes wrong
        - Use bindvars in the queries, for SQLite, its not an option but a requirement
    
      html/modules/base/xarinit.php
        1.135 04/11/06 09:18:22 [email protected] +22 -26
        - Do the config var like the others
        - bindvars are required for SQLite
    
      html/modules/adminpanels/xarinit.php
        1.51 04/11/06 09:18:22 [email protected] +20 -20
        bindvars, needed for SQLite
    
      html/includes/xarTableDDL.php
        1.63 04/11/06 09:18:22 [email protected] +252 -2
        SQLite DDL function added in their absolute minimal form. Based off the mysql varieties. As SQLite is typeless, 
        almost anything goes. Obviously we have to optimize that later, but TableDDL is deprecated anyway ;-)
    
Links for the differences:
http://xaraya.com:15000/core/stable/[email protected]
http://xaraya.com:15000/core/stable/[email protected]
http://xaraya.com:15000/core/stable/[email protected]
http://xaraya.com:15000/core/stable/[email protected]
http://xaraya.com:15000/core/stable/[email protected]
http://xaraya.com:15000/core/stable/[email protected]
http://xaraya.com:15000/core/stable/[email protected]
http://xaraya.com:15000/core/stable/[email protected]
http://xaraya.com:15000/core/stable/[email protected]
http://xaraya.com:15000/core/stable/[email protected]
http://xaraya.com:15000/core/stable/[email protected]
http://xaraya.com:15000/core/stable/[email protected]
http://xaraya.com:15000/core/stable/[email protected]
http://xaraya.com:15000/core/stable/[email protected]
http://xaraya.com:15000/core/stable/[email protected]
http://xaraya.com:15000/core/stable/[email protected]
http://xaraya.com:15000/core/stable/[email protected]
http://xaraya.com:15000/core/stable/[email protected]
http://xaraya.com:15000/core/stable/[email protected]
http://xaraya.com:15000/core/stable/[email protected]
http://xaraya.com:15000/core/stable/[email protected]
http://xaraya.com:15000/core/stable/[email protected]
http://xaraya.com:15000/core/stable/[email protected]
http://xaraya.com:15000/core/stable/[email protected]
http://xaraya.com:15000/core/stable/[email protected]