Re: Debugging some Xaraya CSS quirk
Marty Vance <[email protected]>
| Newsgroups | gmane.comp.cms.xaraya.devel |
|---|---|
| Organization | Xaraya |
| Message-ID | <[email protected]> |
Karsten Poppe wrote: > I did a research on how Xaraya is handling CSS and found some minor bugs > concerning mainly some css classes (typos, non standard classes). > > I won't add this stuff to bugzilla, since I guess it makes no sense to > sort the results per module. > > Its Bug Fix Weekend, so perhaps anybody could address these problems, > should not take too much time. > > Research file: <http://support.metaphora.de/zeugs/xaraya_css.txt> > > > -- Karsten > This is some quite extensive research. I agree with all of your recommendations, except: 2.11: Need to look closer 2.12: Need to look closer 2.13: Need to look closer 2.16: Rename to xar-[modname]-formwidget and define in each module, standardize it, or remove it. Need to look closer 2.17: Need to look closer 2.18: Need to look closer 2.20: Need to look closer 2.29: .xar-pager should be added to required classes in theme CSS 2.33: I think .xar-title is a remnant from PostNuke, where its purpose was to fake a headline by appearance, not semantics. The list of occurances supports this, where we see it applied most often to <span>, which has no semantic meaning. I agree the class should be removed, but the intent of it should also be achieved by semantic markup. I will address your list in the 1x core. While preparing a new draft of the Xaraya Style Guide yesterday, I noticed that the core CSS contains two redundant classes: xar-align-center and xar-center. The latter should be removed. Also, I've had some improvements/additions to Theme and Core CSS in my head for a while, but I've resisted implementing them until the project is more organized.