Re: 1.2M6: Granular HTTPS Support

Jason <[email protected]> Fri, 24 Apr 2009 09:48:34 +0100
Newsgroups gmane.comp.cms.xaraya.devel
Organization Xaraya
Message-ID <[email protected]>
Jason wrote:
> Would't this be best simply as a module? A module could keep a lookup table of
> which URLs should  be secure, what the rules for switching between the two are,
> hook into the page load event and do a redirect to the secure or non-secure
> equivalent page if necessary. It could also set a global that affects the
> protocol for all URLs generated on that page.
> Adding a new parameter just seems wrong. It is putting the entire control into
> the hands of the developer, with no way for the site administrator to decide
> which areas of the site are to use secure URLs.

I'll add to this - events.

IMO there are not enough events in Xaraya. An event in xarModURL() would allow
an installed "define which URLs are SSL" module to modify any URL that is
generated. That could include setting a URL to a secure protocol (even when the
current page is not secure) and vice-versa. It could also include the ability to
inject additional parameters and path components to URLs, which I can think of
plenty of uses for, but is a separate issue, though it would come as a free
benefit on the side.

Any change that is about making the core lighter and more flexible, I would be
fully behind. Changes that make it heavier, bigger and more clunky, are just
going down the wrong path IMO. That includes sweeping changes that require
making many copy/paste changes across the full range of modules that are
available, without actually making the whole system lighter.

-- Jason