Re: filteredTreeNodes // recursive
"Christian Meier" <[email protected]>
| Newsgroups | gmane.comp.cms.zms.devel |
|---|---|
| Message-ID | <[email protected]> |
We faced big performance problems due to - in our opinion unexpected - recursive handling in ZMSContainerObject.filteredTreeNodes. I renewed our patch proposal for zms-2.11.1-900: http://zmslabs.org/trac/attachment/ticket/68/filteredTreeNodes.patch CM. --- In [email protected], "Christian Meier" <post@...> wrote: > > Hello, > > in ZMSContainerObject.filteredTreeNodes (line 912) the check for recursive > search in subtree does not work for meta_types=PAGEELEMENTS, because if ob > is a page-node, it is not appended (ob.isMetaType(meta_types)==FALSE) - and > so the first if-check is always TRUE - whether recursive is set to TRUE or > FALSE: > > if not append or (append and recursive): > if ob.isPage(): > > rtn.extend(ob.filteredTreeNodes(REQUEST,meta_types,None,order_dir,None,recur > sive)) > > In my opinion the following condition is adequate for both - PAGES and > PAGEELEMENTS: > > if ob.isPage() and recursive: > > rtn.extend(ob.filteredTreeNodes(REQUEST,meta_types,None,order_dir,None,recur > sive)) > > Regards, Christian Meier >