Re: incorrect implementation of timezone in ZMSGlobals.getLangFmtDate

"dr_frank_hoffmann" <[email protected]> Mon, 14 May 2012 11:41:56 -0000
Newsgroups	gmane.comp.cms.zms.devel
Message-ID	<[email protected]>
--nvfyUzEqSbPtFUibVYMChV-bLJKFdyHy-7kPD-0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Thank you very much for the fix:
http://zmslabs.org/trac/changeset/1878
It is in the latest build now:
http://zmslabs.org/download/ZMS-latest.tar.gz

Best regards
fh. moderator=20

--- In [email protected], "Wolfgang Huber" <Wolfgang.Huber@...=
> wrote:
>
> Hi,
>=20
> I noticed a  small bug with regard to the timezone in the function
> getLangFmtDate :
>=20
> quote:
>=20
> 1564           if tz < 0:=20=20
> 1565             tch =3D '-'=20=20
>=20
> unquote
>=20
> but the sign is defined as=20
>=20
> quote ( http://docs.python.org/library/time.html)
>=20
> time.timezone
> The offset of the local (non-DST) timezone, in seconds west of UTC
> (negative in most of Western Europe, positive in the US, zero in the
> UK).
>=20
> unquote
>=20
> which is quite the opposite to the usual definition as eg in RFC 822 .
>=20
> so line 1564 should be changed into:
>=20
> 1564           if tz > 0:
>=20
>=20
> regards,
>=20
> Wolfgang Huber
>=20
> --=20
> Wolfgang Huber
> Informationsmanagement, Anwendersysteme
> Web Engineer
>=20
> Johannes Kepler Universit=C3=A4t
> Altenbergerstra=C3=9Fe 69
> 4040 Linz, =C3=96sterreich
>


--nvfyUzEqSbPtFUibVYMChV-bLJKFdyHy-7kPD-0
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable




<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/htm=
l4/strict.dtd">
<html>
<head>
</head>







<body style=3D"background-color: #fff;">
<span style=3D"display:none">&nbsp;</span>

<!--~-|**|PrettyHtmlStartT|**|-~-->
<div id=3D"ygrp-mlmsg" style=3D"position:relative;">
  <div id=3D"ygrp-msg" style=3D"z-index: 1;">
<!--~-|**|PrettyHtmlEndT|**|-~-->

    <div id=3D"ygrp-text" >
=20=20=20=20=20=20
=20=20=20=20=20=20
      <p>Thank you very much for the fix:<br>
<a href=3D"http://zmslabs.org/trac/changeset/1878">http://zmslabs.org/trac/=
changeset/1878</a><br>
It is in the latest build now:<br>
<a href=3D"http://zmslabs.org/download/ZMS-latest.tar.gz">http://zmslabs.or=
g/download/ZMS-latest.tar.gz</a><br>
<br>
Best regards<br>
fh. moderator <br>
<br>
--- In <a href=3D"mailto:zms-developers%40yahoogroups.com">zms-developers@y=
ahoogroups.com</a>, &quot;Wolfgang Huber&quot; &lt;Wolfgang.Huber@...&gt; w=
rote:<br>
&gt;<br>
&gt; Hi,<br>
&gt; <br>
&gt; I noticed a  small bug with regard to the timezone in the function<br>
&gt; getLangFmtDate :<br>
&gt; <br>
&gt; quote:<br>
&gt; <br>
&gt; 1564           if tz &lt; 0:  <br>
&gt; 1565             tch =3D '-'  <br>
&gt; <br>
&gt; unquote<br>
&gt; <br>
&gt; but the sign is defined as <br>
&gt; <br>
&gt; quote ( <a href=3D"http://docs.python.org/library/time.html">http://do=
cs.python.org/library/time.html</a>)<br>
&gt; <br>
&gt; time.timezone<br>
&gt; The offset of the local (non-DST) timezone, in seconds west of UTC<br>
&gt; (negative in most of Western Europe, positive in the US, zero in the<b=
r>
&gt; UK).<br>
&gt; <br>
&gt; unquote<br>
&gt; <br>
&gt; which is quite the opposite to the usual definition as eg in RFC 822 .=
<br>
&gt; <br>
&gt; so line 1564 should be changed into:<br>
&gt; <br>
&gt; 1564           if tz &gt; 0:<br>
&gt; <br>
&gt; <br>
&gt; regards,<br>
&gt; <br>
&gt; Wolfgang Huber<br>
&gt; <br>
&gt; -- <br>
&gt; Wolfgang Huber<br>
&gt; Informationsmanagement, Anwendersysteme<br>
&gt; Web Engineer<br>
&gt; <br>
&gt; Johannes Kepler Universit=C3=A4t<br>
&gt; Altenbergerstra=C3=9Fe 69<br>
&gt; 4040 Linz, =C3=96sterreich<br>
&gt;<br>
<br>
</p>

    </div>
=20=20=20=20=20

    <!--~-|**|PrettyHtmlStart|**|-~-->
    <div style=3D"color: #fff; height: 0;">__._,_.___</div>

=20=20=20=20=20=20=20=20
=20=20
=20=20=20
    <div id=3D"ygrp-actbar" style=3D"clear: both; margin-bottom: 10px; whit=
e-space: nowrap; color: #666; padding-top: 15px;">
      <div>
        <a href=3D"mailto:[email protected]?subject=3DRe%3A%20incor=
rect%20implementation%20of%20timezone%20in%20ZMSGlobals%2EgetLangFmtDate" s=
tyle=3D"margin-right: 0; padding-right: 0;">
	  Reply to <span style=3D"font-weight: 700;">sender</span></a> |
        <a href=3D"mailto:[email protected]?subject=3DRe%3A%20=
incorrect%20implementation%20of%20timezone%20in%20ZMSGlobals%2EgetLangFmtDa=
te">
	  Reply to <span style=3D"font-weight: 700;">group</span></a> |
        	  <a href=3D"http://groups.yahoo.com/group/zms-developers/post;_yl=
c=3DX3oDMTJwaTdnMTNyBF9TAzk3MzU5NzE0BGdycElkAzg0NzA4MjEEZ3Jwc3BJZAMxNzA3Mjg=
xOTQyBG1zZ0lkAzM3OTQEc2VjA2Z0cgRzbGsDcnBseQRzdGltZQMxMzM2OTk1NzIw?act=3Drep=
ly&messageNum=3D3794">Reply <span style=3D"font-weight: 700;">via web post<=
/span></a> |
            	<a href=3D"http://groups.yahoo.com/group/zms-developers/post;_=
ylc=3DX3oDMTJlYjZrNmdiBF9TAzk3MzU5NzE0BGdycElkAzg0NzA4MjEEZ3Jwc3BJZAMxNzA3M=
jgxOTQyBHNlYwNmdHIEc2xrA250cGMEc3RpbWUDMTMzNjk5NTcyMA--" style=3D"font-weig=
ht: 700;">Start a New Topic</a>
      </div>

                <a href=3D"http://groups.yahoo.com/group/zms-developers/mes=
sage/3770;_ylc=3DX3oDMTM0bWJlMmI4BF9TAzk3MzU5NzE0BGdycElkAzg0NzA4MjEEZ3Jwc3=
BJZAMxNzA3MjgxOTQyBG1zZ0lkAzM3OTQEc2VjA2Z0cgRzbGsDdnRwYwRzdGltZQMxMzM2OTk1N=
zIwBHRwY0lkAzM3NzA-">Messages in this topic</a>
          (<span style=3D"font-weight: 700;">19</span>)
          </div>=20
<!------- Start Nav Bar ------>

<!-- |**|begin egp html banner|**| -->
<div id=3D"ygrp-vital" style=3D"background-color: #e0ecee; font-family: Ver=
dana; font-size: 10px; margin-bottom: 10px; padding: 10px;">
      <span id=3D"vithd" style=3D"font-weight: bold; color: #333; text-tran=
sform: uppercase; ">Recent Activity:</span>

    <ul style=3D"list-style-type: none; margin: 0; padding: 0; display: inl=
ine;">
                                                    </ul>
=20=20=20=20
  <div style=3D"clear: both; padding-top: 2px; color: #1e66ae;">
    <a href=3D"http://groups.yahoo.com/group/zms-developers;_ylc=3DX3oDMTJl=
bGwydWUyBF9TAzk3MzU5NzE0BGdycElkAzg0NzA4MjEEZ3Jwc3BJZAMxNzA3MjgxOTQyBHNlYwN=
2dGwEc2xrA3ZnaHAEc3RpbWUDMTMzNjk5NTcxOQ--" style=3D"text-decoration: none;"=
>Visit Your Group</a>
  </div>
</div>

=20=20
<div id=3D"ft" style=3D"font-family: Arial; font-size: 11px; margin-top: 5p=
x; padding: 0 2px 0 0; clear: both;">
  <a href=3D"http://groups.yahoo.com/;_ylc=3DX3oDMTJkbzN0OHE0BF9TAzk3MzU5Nz=
E0BGdycElkAzg0NzA4MjEEZ3Jwc3BJZAMxNzA3MjgxOTQyBHNlYwNmdHIEc2xrA2dmcARzdGltZ=
QMxMzM2OTk1NzIw" style=3D"float: left;"><img src=3D"http://l.yimg.com/a/i/u=
s/yg/logo/us.gif" height=3D"15" width=3D"137" alt=3D"Yahoo! Groups" style=
=3D"border: 0;"/></a>
  <div style=3D"color: #747575; float: right;">Switch to: <a href=3D"mailto=
:[email protected]?subject=3DChange Delivery Forma=
t: Traditional" style=3D"text-decoration: none;">Text-Only</a>, <a href=3D"=
mailto:[email protected]?subject=3DEmail Delivery: Dige=
st" class=3D"margin-rt" style=3D"text-decoration: none;">Daily Digest</a> &=
bull; <a href=3D"mailto:[email protected]?subject=
=3DUnsubscribe" style=3D"text-decoration: none;">Unsubscribe</a> &bull; <a =
href=3D"http://docs.yahoo.com/info/terms/" style=3D"text-decoration: none;"=
>Terms of Use</a></div>
</div>

<!-- |**|end egp html banner|**| -->

  </div> <!-- ygrp-msg -->

  <!-- Sponsor -->
  <!-- |**|begin egp html banner|**| -->
  <div id=3D"ygrp-sponsor" style=3D"width:160px; float:right; clear:none; m=
argin:0 0 25px 0; background: #fff;">

<!-- Start Recommendations -->
<div id=3D"ygrp-reco">
     </div>
<!-- End Recommendations -->



  </div>   <!-- |**|end egp html banner|**| -->

  <div style=3D"clear:both; color: #FFF; font-size:1px;">.</div>
</div>

  <img src=3D"http://geo.yahoo.com/serv?s=3D97359714/grpId=3D8470821/grpspI=
d=3D1707281942/msgId=3D3794/stime=3D1336995720/nc1=3D4507179/nc2=3D5741398/=
nc3=3D3848642" width=3D"1" height=3D"1"> <br>

<div style=3D"color: #fff; height: 0;">__,_._,___</div>
<!--~-|**|PrettyHtmlEnd|**|-~-->

</body>

<!--~-|**|PrettyHtmlStart|**|-~-->
<head>
  <style type=3D"text/css">
  <!--
  #ygrp-mkp {
  border: 1px solid #d8d8d8;
  font-family: Arial;
  margin: 10px 0;
  padding: 0 10px;
}

#ygrp-mkp hr {
  border: 1px solid #d8d8d8;
}

#ygrp-mkp #hd {
  color: #628c2a;
  font-size: 85%;
  font-weight: 700;
  line-height: 122%;
  margin: 10px 0;
}

#ygrp-mkp #ads {
  margin-bottom: 10px;
}

#ygrp-mkp .ad {
  padding: 0 0;
}

#ygrp-mkp .ad p {
  margin: 0;
}

#ygrp-mkp .ad a {
  color: #0000ff;
  text-decoration: none;
}
  #ygrp-sponsor #ygrp-lc {
  font-family: Arial;
}

#ygrp-sponsor #ygrp-lc #hd {
  margin: 10px 0px;
  font-weight: 700;
  font-size: 78%;
  line-height: 122%;
}

#ygrp-sponsor #ygrp-lc .ad {
  margin-bottom: 10px;
  padding: 0 0;
}

  a {
    color: #1e66ae;
  }

  #actions {
    font-family: Verdana;
    font-size: 11px;
    padding: 10px 0;
  }

  #activity {
    background-color: #e0ecee;
    float: left;
    font-family: Verdana;
    font-size: 10px;
    padding: 10px;
  }

  #activity span {
    font-weight: 700;
  }

  #activity span:first-child {
    text-transform: uppercase;
  }

  #activity span a {
    color: #5085b6;
    text-decoration: none;
  }

  #activity span span {
    color: #ff7900;
  }

  #activity span .underline {
    text-decoration: underline;
  }

  .attach {
    clear: both;
    display: table;
    font-family: Arial;
    font-size: 12px;
    padding: 10px 0;
    width: 400px;
  }

  .attach div a {
    text-decoration: none;
  }

  .attach img {
    border: none;
    padding-right: 5px;
  }

  .attach label {
    display: block;
    margin-bottom: 5px;
  }

  .attach label a {
    text-decoration: none;
  }
=20=20
  blockquote {
    margin: 0 0 0 4px;
  }

  .bold {
    font-family: Arial;
    font-size: 13px;
    font-weight: 700;
  }

  .bold a {
    text-decoration: none;
  }

  dd.last p a {
    font-family: Verdana;
    font-weight: 700;
  }

  dd.last p span {
    margin-right: 10px;
    font-family: Verdana;
    font-weight: 700;
  }

  dd.last p span.yshortcuts {
    margin-right: 0;
  }

  div.attach-table div div a {
    text-decoration: none;
  }

  div.attach-table {
    width: 400px;
  }

  div.file-title a, div.file-title a:active, div.file-title a:hover, div.fi=
le-title a:visited {
    text-decoration: none;
  }

  div.photo-title a, div.photo-title a:active, div.photo-title a:hover, div=
.photo-title a:visited {
    text-decoration: none;
  }

  div#ygrp-mlmsg #ygrp-msg p a span.yshortcuts {
    font-family: Verdana;
    font-size: 10px;
    font-weight: normal;
  }

  .green {
    color: #628c2a;
  }

  .MsoNormal {
    margin: 0 0 0 0;
  }

  o {
    font-size: 0;
  }

  #photos div {
    float: left;
    width: 72px;
  }

  #photos div div {
    border: 1px solid #666666;
    height: 62px;
    overflow: hidden;
    width: 62px;
  }

  #photos div label {
    color: #666666;
    font-size: 10px;
    overflow: hidden;
    text-align: center;
    white-space: nowrap;
    width: 64px;
  }

  #reco-category {
    font-size: 77%;
  }

  #reco-desc {
    font-size: 77%;
  }

  .replbq {
    margin: 4px;
  }

  #ygrp-actbar div a:first-child {
   /* border-right: 0px solid #000;*/
    margin-right: 2px;
    padding-right: 5px;
  }

  #ygrp-mlmsg {
    font-size: 13px;
    font-family: Arial, helvetica,clean, sans-serif;
    *font-size: small;
    *font: x-small;
  }

  #ygrp-mlmsg table {
    font-size: inherit;
    font: 100%;
  }

  #ygrp-mlmsg select, input, textarea {
    font: 99% Arial, Helvetica, clean, sans-serif;
  }

  #ygrp-mlmsg pre, code {
    font:115% monospace;
    *font-size:100%;
  }

  #ygrp-mlmsg * {
    line-height: 1.22em;
  }

  #ygrp-mlmsg #logo {
    padding-bottom: 10px;
  }

  #ygrp-mlmsg a {
    color: #1E66AE;
  }

  #ygrp-msg p a {
    font-family: Verdana;
  }

  #ygrp-msg p#attach-count span {
    color: #1E66AE;
    font-weight: 700;
  }

  #ygrp-reco #reco-head {
    color: #ff7900;
    font-weight: 700;
  }

  #ygrp-reco {
    margin-bottom: 20px;
    padding: 0px;
  }

  #ygrp-sponsor #ov li a {
    font-size: 130%;
    text-decoration: none;
  }

  #ygrp-sponsor #ov li {
    font-size: 77%;
    list-style-type: square;
    padding: 6px 0;
  }=20

  #ygrp-sponsor #ov ul {
    margin: 0;
    padding: 0 0 0 8px;
  }

  #ygrp-text {
    font-family: Georgia;
  }

  #ygrp-text p {
    margin: 0 0 1em 0;
  }

  #ygrp-text tt {
    font-size: 120%;
  }

  #ygrp-vital ul li:last-child {
    border-right: none !important;=20
  }=20
  -->
  </style>
</head>

<!--~-|**|PrettyHtmlEnd|**|-~-->
</html>
<!-- end group email -->


--nvfyUzEqSbPtFUibVYMChV-bLJKFdyHy-7kPD-0--