Re: Support for color diagnostics
Joel Rosdahl <[email protected]> Thu, 7 Aug 2014 22:27:07 +0200
| Newsgroups | gmane.comp.compilers.ccache |
|---|---|
| Message-ID | <CAK8D=pjfa-=EDS2LThvPrgU+5sxhVY3_jn-XBySgvSZ1pJhSPg@mail.gmail.com> |
> > Attached is an updated patch that passes also all the tests. Applied on master, thanks! (Sorry for the massive delay.) -- Joel On 26 June 2014 18:44, Lubos Lunak <[email protected]> wrote: > On Saturday 14 of June 2014, Joel Rosdahl wrote: > > Hi Lubos, > > > > Sorry about the ping delay. I've now looked at your patch and it looks > > promising. > ... > > I suggest passing the argument list as an argument to the compiler_is_* > > functions instead of relying on global variables. > > > > When extracting the compiler name, I suggest using basename() from > util.c. > > That way it will work on Windows as well. > > Attached is an updated patch that passes also all the tests. > > -- > Lubos Lunak > > _______________________________________________ > ccache mailing list > [email protected] > https://lists.samba.org/mailman/listinfo/ccache > >