[PATCH]: test: export SHELL from Makefile
Eric Bavier <[email protected]> Tue, 14 Jul 2015 18:13:49 -0500
| Newsgroups | gmane.comp.compilers.ccache |
|---|---|
| Message-ID | <[email protected]> |
Hello ccache devs,
I get the following test failure when 'SHELL' is not
defined in the environment when `make check` is run (e.g. it is defined
when calling 'configure' instead: `SHELL=/usr/bin configure
--prefix=...`):
test/test_util.c:99: Failed assertion:
Suite: util
Test: subst_env_in_string
Expression: subst_env_in_string("$SHELL", &errmsg)
Expected: (null)
Actual: (null)
However, SHELL is exported by 'configure', so we can easily export its
value when running test/main. The attached patch does just this. I
hope you can consider applying it.
Happy Hacking,
`~Eric
_______________________________________________
ccache mailing list
[email protected]
https://lists.samba.org/mailman/listinfo/ccache
ccache-check-SHELL.patch
(text/x-patch, 533 B)
--- ccache-3.2.2/Makefile.in.orig 2015-05-10 07:24:44.000000000 -0500 +++ ccache-3.2.2/Makefile.in 2015-07-09 20:01:08.035640777 -0500 @@ -17,6 +17,7 @@ LDFLAGS = @LDFLAGS@ LIBS = @LIBS@ RANLIB = @RANLIB@ +SHELL = @SHELL@ all_cflags = $(CFLAGS) all_cppflags = @DEFS@ @extra_cppflags@ -DSYSCONFDIR=$(sysconfdir) -I. -I$(srcdir) $(CPPFLAGS) @@ -80,7 +81,7 @@ .PHONY: test test: ccache$(EXEEXT) test/main$(EXEEXT) - test/main$(EXEEXT) + SHELL='$(SHELL)' test/main$(EXEEXT) CC='$(CC)' $(srcdir)/test.sh .PHONY: quicktest