Re: [PATCH]: test: export SHELL from Makefile

On Wed, 5 Aug 2015 17:50:32 +0200
Joel Rosdahl <[email protected]> wrote:

> Hi Eric,
> 
> I get the following test failure when 'SHELL' is not defined in the
> > environment [...]
> > SHELL is exported by 'configure', so we can easily export its value
> > when running
> > test/main. The attached patch does just this. I hope you can
> > consider applying it.
> 
> 
> Thanks for the patch!
> 
> The subst_env_in_string test only needs any arbitrary environment
> variable to play with, so I suggest making the test set up its own
> environment instead of relying on an external variable being set. I
> made it so in 14ea3b69801213eee7aaa0a64f7d0144d23f58a1
> <https://git.samba.org/?p=ccache.git;a=commit;h=14ea3b69801213eee7aaa0a64f7d0144d23f58a1>.
> Are you OK with that approach?

Even better.  Thank you!

`~Eric