Re: [distcc-patches] [patch] Add a few missing bits for OS X support

Sorry for the very slow response to this patch.

The patch looks good, except for the part

+  def include_sysroot(self):
+    # FIXME: Is this the correct precedence for isysroot and sysroot?
+    if self.sysroot:
+      return self.sysroot
+    return self.isysroot

where the correct precedence is the other way around.

I have changed that part so that isysroot takes precedence, and submitted
this CL as revision 783 in the distcc svn repository.

On Tue, Dec 20, 2011 at 6:43 PM, Rafael Ávila de Espíndola <
[email protected]> wrote:

> The attached patch is not complete, but it adds enough features and
> fixes to let distcc pump build a slightly patched version of firefox
> on OS X.
>
> What the patch does is
>
> * add support for -isysroot and -arch
> * Fix a really nasty corner case:
>   * CompressFiles::Compress uses os.makedirs to create a directory
> (foo)  for one compilation unit
>   * Another compilation unit does the equivalent of '#include
> "foo/../bar.h"'
>   * The compilation unit uses no other file in foo
>   * We conclude that we don't have to create a dummy
> foo/forcing_technique_271828
>
> Cheers,
> Rafael
>
> --
> You received this message because you are subscribed to the
> "distcc-patches" list.
> To post to this list, send email to <[email protected]>.
> To unsubscribe from this list, send email to <
> [email protected]>.
> For archives and more options, see <
> http://groups.google.com/group/distcc-patches>.




-- 
Fergus Henderson <[email protected]>

"Defend the user, exclude no one, and create magic." -- Eric Schmidt.

__
distcc mailing list            http://distcc.samba.org/
To unsubscribe or change options:
https://lists.samba.org/mailman/listinfo/distcc