Re: Patch for omniORBpy pyTypeCode.cc
Duncan Grisby <[email protected]> Tue, 16 Mar 2004 15:59:41 +0000
| Newsgroups | gmane.comp.corba.omniorb.devel |
|---|---|
| Message-ID | <[email protected]> |
On Monday 15 March, Alex Tingle wrote: > The patch adds the missing ref count increments. It's tested insofar as > it cured my SEGV & assertion failure problems (only with structs, not > tested with exceptions or unions but it seems a safe bet that they work > the same way). > > Caveat: My first look at the omniORBpy code. Hope I've got the right end > of the stick! Thanks. It's the correct fix. I guess this goes to show that people hardly ever use identifiers that clash with Python keywords. For future reference, it's better if you use unified or context diff format rather than traditional diffs, since they're more robust against changes in the code, and they're easier to read. In this case the fix was so trivial it's no big deal, though. Cheers, Duncan. -- -- Duncan Grisby -- -- [email protected] -- -- http://www.grisby.org --